Skip to content

Commit d5e4885

Browse files
authored
Merge pull request #354 from kabalin/bump-selenium-image
Bump selenium image to version 4
2 parents d3e0af6 + 229b485 commit d5e4885

File tree

5 files changed

+15
-6
lines changed

5 files changed

+15
-6
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ jobs:
7878
- php: '8.4'
7979
moodle-branch: 'main'
8080
moodle-app: 'true'
81+
- php: '8.4'
82+
moodle-branch: 'MOODLE_500_STABLE'
83+
moodle-app: 'true'
8184
- php: '8.3'
8285
moodle-branch: 'MOODLE_405_STABLE'
8386
moodle-app: 'true'
@@ -205,6 +208,9 @@ jobs:
205208
- php: '8.4'
206209
moodle-branch: 'main'
207210
moodle-app: 'true'
211+
- php: '8.4'
212+
moodle-branch: 'MOODLE_500_STABLE'
213+
moodle-app: 'true'
208214
- php: '8.3'
209215
moodle-branch: 'MOODLE_405_STABLE'
210216
moodle-app: 'true'

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ jobs:
9595
- MOODLE_BRANCH=main
9696
- MOODLE_APP=true
9797
# Last stable with highest supported PHP version.
98-
- php: 8.3
98+
- php: 8.4
9999
env:
100-
- MOODLE_BRANCH=MOODLE_405_STABLE
100+
- MOODLE_BRANCH=MOODLE_500_STABLE
101101
- MOODLE_APP=true
102102
# And older stable supported (with lowest supported PHP version).
103103
- php: 7.4

docs/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ This project adheres to [Semantic Versioning](https://semver.org/).
99
The format of this change log follows the advice given at [Keep a CHANGELOG](https://keepachangelog.com).
1010

1111
## [Unreleased]
12+
### Changed
13+
- Bump default Selenium version to 4.
14+
1215
## [4.5.7] - 2025-03-26
1316
### Changed
1417
- Allow to run with PHP 8.4 (supported in Moodle 5.0)

src/Command/BehatCommand.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,13 +223,13 @@ private function getSeleniumImage(InputInterface $input, string $profile): strin
223223
}
224224

225225
if ($profile === 'chrome') {
226-
return getenv('MOODLE_APP') ? 'selenium/standalone-chrome:120.0' : 'selenium/standalone-chrome:3';
226+
return 'selenium/standalone-chrome:4';
227227
}
228228

229229
if ($this->usesLegacyPhpWebdriver()) {
230230
return 'selenium/standalone-firefox:2.53.1';
231231
}
232232

233-
return 'selenium/standalone-firefox:3';
233+
return 'selenium/standalone-firefox:4';
234234
}
235235
}

tests/Command/BehatCommandTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public function testExecuteWithChromeProfile()
9494

9595
$commandTester = $this->executeCommand(null, null, ['--start-servers' => true, '--profile' => 'chrome']);
9696
$this->assertSame(0, $commandTester->getStatusCode());
97-
$this->assertMatchesRegularExpression('/selenium\/standalone-chrome:3/', $this->allCmds[1]);
97+
$this->assertMatchesRegularExpression('/selenium\/standalone-chrome:4/', $this->allCmds[1]);
9898
}
9999

100100
public function testExecuteWithFirefoxProfile()
@@ -104,7 +104,7 @@ public function testExecuteWithFirefoxProfile()
104104

105105
$commandTester = $this->executeCommand(null, null, ['--start-servers' => true, '--profile' => 'firefox']);
106106
$this->assertSame(0, $commandTester->getStatusCode());
107-
$this->assertMatchesRegularExpression('/selenium\/standalone-firefox:3/', $this->allCmds[1]);
107+
$this->assertMatchesRegularExpression('/selenium\/standalone-firefox:4/', $this->allCmds[1]);
108108
}
109109

110110
public function testExecuteWithLegacyFirefoxProfile()

0 commit comments

Comments
 (0)