Skip to content

Commit b79e7da

Browse files
committed
List just artist's albums instead of albums and songs
1 parent 9ef234a commit b79e7da

File tree

4 files changed

+24
-277
lines changed

4 files changed

+24
-277
lines changed

app/src/main/java/com/naman14/timber/adapters/ArtistSongAdapter.java

Lines changed: 0 additions & 244 deletions
This file was deleted.

app/src/main/java/com/naman14/timber/fragments/ArtistMusicFragment.java

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,26 @@
1616

1717
import android.os.Bundle;
1818
import android.support.v4.app.Fragment;
19-
import android.support.v7.widget.LinearLayoutManager;
19+
import android.support.v7.widget.GridLayoutManager;
2020
import android.support.v7.widget.RecyclerView;
2121
import android.view.LayoutInflater;
2222
import android.view.View;
2323
import android.view.ViewGroup;
2424

2525
import com.naman14.timber.R;
26-
import com.naman14.timber.adapters.ArtistSongAdapter;
27-
import com.naman14.timber.dataloaders.ArtistSongLoader;
28-
import com.naman14.timber.models.Song;
26+
import com.naman14.timber.adapters.AlbumAdapter;
27+
import com.naman14.timber.adapters.ArtistAlbumAdapter;
28+
import com.naman14.timber.dataloaders.ArtistAlbumLoader;
29+
import com.naman14.timber.models.Album;
2930
import com.naman14.timber.utils.Constants;
30-
import com.naman14.timber.widgets.DividerItemDecoration;
3131

3232
import java.util.ArrayList;
3333

3434
public class ArtistMusicFragment extends Fragment {
3535

36-
public static RecyclerView songsRecyclerview;
36+
public static RecyclerView albumsRecyclerView;
3737
long artistID = -1;
38-
ArtistSongAdapter mSongAdapter;
38+
AlbumAdapter albumAdapter;
3939

4040
public static ArtistMusicFragment newInstance(long id) {
4141
ArtistMusicFragment fragment = new ArtistMusicFragment();
@@ -58,28 +58,21 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
5858
View rootView = inflater.inflate(
5959
R.layout.fragment_artist_music, container, false);
6060

61-
songsRecyclerview = (RecyclerView) rootView.findViewById(R.id.recycler_view_songs);
61+
albumsRecyclerView = (RecyclerView) rootView.findViewById(R.id.recycler_view_albums);
6262

63-
setUpSongs();
63+
setUpAlbums();
6464

6565

6666
return rootView;
6767
}
6868

6969

70-
private void setUpSongs() {
71-
songsRecyclerview.setLayoutManager(new LinearLayoutManager(getActivity()));
70+
private void setUpAlbums() {
71+
albumsRecyclerView.setLayoutManager(new GridLayoutManager(getActivity(), 2));
7272

73-
ArrayList<Song> songList;
74-
songList = ArtistSongLoader.getSongsForArtist(getActivity(), artistID);
75-
76-
// adding one dummy song to top of arraylist
77-
//there will be albums header at this position in recyclerview
78-
songList.add(0, new Song(-1, -1, -1, "dummy", "dummy", "dummy", -1, -1));
79-
80-
mSongAdapter = new ArtistSongAdapter(getActivity(), songList, artistID);
81-
songsRecyclerview.addItemDecoration(new DividerItemDecoration(getActivity(), DividerItemDecoration.VERTICAL_LIST));
82-
songsRecyclerview.setAdapter(mSongAdapter);
73+
ArrayList<Album> albumList = ArtistAlbumLoader.getAlbumsForArtist(getActivity(), artistID);
74+
ArtistAlbumAdapter albumAdapter = new ArtistAlbumAdapter(getActivity(), albumList);
75+
albumsRecyclerView.setAdapter(albumAdapter);
8376
}
8477

8578

app/src/main/res/layout/fragment_artist_music.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<android.support.v7.widget.RecyclerView
44
xmlns:android="http://schemas.android.com/apk/res/android"
55
xmlns:app="http://schemas.android.com/apk/res-auto"
6-
android:id="@+id/recycler_view_songs"
6+
android:id="@+id/recycler_view_albums"
77
android:layout_width="match_parent"
88
android:layout_height="match_parent"
99
app:layout_behavior="@string/appbar_scrolling_view_behavior"/>

app/src/main/res/layout/item_artist_album.xml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,24 @@
11
<android.support.v7.widget.CardView
22
xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:app="http://schemas.android.com/apk/res-auto"
4-
android:layout_width="104dp"
5-
android:layout_height="150dp"
4+
android:layout_width="match_parent"
5+
android:layout_height="match_parent"
66
android:foreground="?selectableItemBackgroundBorderless"
77
android:paddingLeft="25dp"
88
app:cardUseCompatPadding="true"
99
android:id="@+id/root_view"
1010
style="?attr/cardStyle">
1111

1212
<RelativeLayout
13-
android:layout_width="104dp"
13+
android:layout_width="match_parent"
1414
android:layout_height="match_parent">
1515

16-
<ImageView
16+
<com.naman14.timber.widgets.SquareImageView
1717
android:id="@+id/album_art"
18-
android:layout_width="104dp"
19-
android:layout_height="104dp"
20-
android:layout_alignParentTop="true"
18+
android:layout_width="match_parent"
19+
android:layout_height="match_parent"
2120
android:scaleType="centerCrop"
22-
android:transitionName="transition_album_art"/>
23-
21+
android:transitionName="transition_album_art" />
2422

2523
<LinearLayout
2624
android:layout_width="match_parent"
@@ -34,7 +32,7 @@
3432

3533
<TextView
3634
android:id="@+id/album_title"
37-
android:layout_width="104dp"
35+
android:layout_width="match_parent"
3836
android:layout_height="wrap_content"
3937
android:layout_gravity="top"
4038
android:ellipsize="end"
@@ -44,7 +42,7 @@
4442

4543
<TextView
4644
android:id="@+id/album_details"
47-
android:layout_width="104dp"
45+
android:layout_width="match_parent"
4846
android:ellipsize="end"
4947
android:singleLine="true"
5048
android:layout_height="wrap_content"

0 commit comments

Comments
 (0)