Truncated JS in 0.8

[KaiserZoza]

Hi.

I'm having an issue with a file being truncated when generated.

the Script# code is like:

namespace A.B.C
{
Public enum foo1{}

    Public enum foo2{}

    Public Class Foo{}

    Public Partial Class FooN: FooA,FooB,FooC
    {

                   //Attributes

                  //Methods

                 //Some methods

//#1--------------->
// Before 0.8 the code had the "[AlternateSignature]"
public extern void setFoo(Type newFoo, string text);
public void setFoo(Type newFoo, string text, string text2)

                  //more methods
     }

}

The resultating JS file is being generated untill #1 the rest of the methods and closing '}' are being truncated. The closing ');' of Deinfe are in the resultating file.

Thanks in advance for your help.

[nikhilk]

Can you share the actual code isolated so it can be compiled to reproduce the problem?
Or if you can't, then suggest building a debug version of the compiler, and seeing if some assert is failing, or the exception that is causing the truncation.

[reymarx]

I found a simple sample which will reproduce this behavior and it's the .Remove() method of a Dictionary. If you compile this S# code:

using System.Collections.Generic;
using System.Html;

namespace IssueSample
{

    public class Class1
    {
        private Dictionary<int, string> myDictionary = new Dictionary<int, string>(); 

        public void method()
        {
                Window.Alert("foo");
                myDictionary.Remove(1);
                Window.Alert("bar");
        }
    }
}

VS won't give any errors or warnings, but the compiled code will be truncated as:

/*! IssueSample.js 1.0.0.0
 * 
 * Copyright ©  2012
 */

"use strict";

define('IssueSample', ['ss'], function(ss) {
  var $global = this;

  // IssueSample.Class1

  function IssueSample$Class1() {
    this._myDictionary = {};
  }
  var IssueSample$Class1$ = {
    method: function() {
      alert('foo');

});

// Generated with Script# 0.8.0.0

Commenting out the line myDictionary.Remove(EnumType.Second); will work as expected.

[reymarx]

I also found that using a plain Dictionary (not generic) will work.

[nikhilk]

Suspected this when I saw the Dictionary<int, string>

The expectation in the code is the key is a string, since that is effectively the behavior of object keys at runtime. I don't think the compiler should implicitly convert literal values (eg. 1 to "1") or introduce toString calls. It could defer this problem to the runtime, and let the script engine do the conversion implicitly. Or create an error if the key type is not a string.

For now I have chosen to make a change to effectively defer to the script engine. However you might want to double check if you do mean to use numeric keys.