-
Notifications
You must be signed in to change notification settings - Fork 115
Open
Labels
Description
In nodejs/node#40613, [email protected]
incorrectly adds a Fixes:
metadata line:
----------------------------------- PR info ------------------------------------
Title crypto: fix build without scrypt (#40613)
Author Martin 'JaMa' Jansa <[email protected]> (@shr-project, first-time contributor)
Branch shr-project:jansa/scrypt -> nodejs:master
Labels crypto, c++, author ready
Commits 1
- crypto: fix build without scrypt
Committers 1
- Martin Jansa <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/40613
Fixes: https://github.com/In
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40613
Fixes: https://github.com/In
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
--------------------------------------------------------------------------------
The commit message was:
crypto: fix build without scrypt
* add missing semicolon to fix:
In file included from ../src/node_crypto.h:47,
from ../src/node.cc:46:
../src/crypto/crypto_scrypt.h:80:2:
error: expected ';' after struct definition
80 | }
| ^
| ;
and fix typo in the comment
Signed-off-by: Martin Jansa <[email protected]>
(Original post in nodejs/node#40613 (comment).)