src: call unmask after install signal handler #59059
Open
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
theanarkh
force-pushed
the
unmask_after_install_handler
branch
from
25f4495 to
a6c462c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59059 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.01%
==========================================
Files 645 645
Lines 189130 189132 +2
Branches 37094 37095 +1
==========================================
- Hits 170339 170331 -8
+ Misses 11511 11506 -5
- Partials 7280 7295 +15
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Jul 15, 2025
benjamingr
approved these changes
Jul 15, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jul 19, 2025
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/59059 ✔ Done loading data for nodejs/node/pull/59059 ----------------------------------- PR info ------------------------------------ Title src: call unmask after install signal handler (#59059) Author theanarkh <[email protected]> (@theanarkh) Branch theanarkh:unmask_after_install_handler -> nodejs:main Labels c++, inspector, needs-ci Commits 1 - src: call unmask after install signal handler Committers 1 - theanarkh <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59059 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59059 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 14 Jul 2025 00:38:52 GMT ✔ Approvals: 3 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/59059#pullrequestreview-3022166848 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/59059#pullrequestreview-3022433572 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/59059#pullrequestreview-3035416061 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-07-19T15:00:42Z: https://ci.nodejs.org/job/node-test-pull-request/68030/ - Querying data for job/node-test-pull-request/68030/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16390436262 |
nodejs-github-bot
added
the
commit-queue-failed
theanarkh
added
request-ci
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
unmaskafter installing signal handler to ensure the signal is caught.make -j4 test(UNIX), orvcbuild test(Windows) passes