Add accessibility features: colorblind support, scent sensitivity guidance, inclusive resources, and refrigerator access for nursing mothers #309
Conversation
There was a problem hiding this comment.
Will put into the editorial review.
Please use more descriptive titles with PRs and commits. Having to look up a series of issue numbers makes it a challenge to find details of what is being solved.
https://github.com/numfocus/DISCOVER-Cookbook/blob/main/CONTRIBUTING.md#pull-request-guidelines
|
Extending @aterrel's comment, you'll have seen that the issue numbers in the PR title are not rendered as links but as plain numbers. In general none of the maintainers will know what an issue is by their number and having the numbers without links is not very useful as it means looking/copying the number, navigating to the issue page and selecting/pasting the issue in question. If you mention the issues in the PR description however (as you have also done) they are rendered as links, but that is not all, you can also use specific keywords to indicate an issue will be fixed by this PR. If you do, the issues you mentioned will be automatically closed when the PR is merged. |
AR21SM
changed the title
AR21SM
changed the title
|
Hi @OriolAbril, I've updated the PR title and description as suggested. Please let me know if there's anything else I should change ? |
#20 added link in Further Reading: 03_organizing_committee.md
#34 added link in Further Reading: 03_organizing_committee.md, 04_venue_selection.md
#40 added a bullet point in 02_minimal_measures.md
#41 added a section in 10_event_registration.md - Scent Sensitivities
#42 added a section in 10_event_registration.md - Support for Nursing Parents
Closes #20, Closes #34, Closes #40, Closes #41, Closes #42