-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Status: TriageThis is being looked at and prioritizedThis is being looked at and prioritizedType: BugSomething isn't working as documentedSomething isn't working as documented
Description
What happened?
The latest release of @octokit/oauth-app (8.0.2) updates the interface for GetUserOctokitWithStateInterface to have 2 required type arguments. The generated types in the current release of octokit were generated off of @octokit/[email protected], causing the package to not compile in Typescript:
// index.ts
import { App } from 'octokit';
const appId = 'myAppId';
const privateKey = 'myPrivateKey';
const myApp = new App({ appId, privateKey });
// tsconfig.json
{
"compilerOptions": {
"target": "esnext",
"module": "nodenext",
"moduleResolution": "nodenext",
"strict": true
}
}Stackblitz reproduction (runkit.com is currently timing out): https://stackblitz.com/edit/node-i7r2pkkz?file=index.ts
- compile with
npx tsc --noEmit
Versions
Octokit.js 5.0.3, TypeScript 5.9.3, NodeJS 20.19.1
Relevant log output
❯ npx tsc --noEmit
node_modules/octokit/dist-types/app.d.ts:79:21 - error TS2314: Generic type 'GetUserOctokitWithStateInterface<TClientType, TOctokitInstance>' requires 2 type argument(s).
79 getUserOctokit: import("@octokit/oauth-app").GetUserOctokitWithStateInterface<"oauth-app">;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error in node_modules/octokit/dist-types/app.d.ts:79Code of Conduct
- I agree to follow this project's Code of Conduct
moeroach94
Metadata
Metadata
Assignees
Labels
Status: TriageThis is being looked at and prioritizedThis is being looked at and prioritizedType: BugSomething isn't working as documentedSomething isn't working as documented
Type
Projects
Status
✅ Done