Skip to content

Prevent modifying the generated files if generate target fails #1090

Open
@omarahmed1111

Description

@omarahmed1111

If we tried to run make generate and it fails, it will still generate some files and some files not, it will also not run clang-format on the generated files. This will be shown as some of the files are modified while they only have been regenerated without the new additions that we added and without being formatted. We could maybe enhance this by prevent the regeneration of all the files while also report a meaningful error of what happened.

For example: if we tried running make generate without installing third_party/requirements.txt and so a missing dependency , it will report a failure with:

Failed to generate specification.
'bytes' object has no attribute 'read'

Note: This is one of the missing dependencies error, it could also fail with other errors depending on which packages are missing

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions