fix: inavlidate empty commits in push events in bitbucket dc

invalidated empty commits in push in bitbucket data center
as we may want to check commit field for commit SHA.

Signed-off-by: Zaki Shaikh <[email protected]>

Author: zakisk

pkg/provider/bitbucketdatacenter/parse_payload.go

@@ -164,6 +164,10 @@ func (v *Provider) ParsePayload(_ context.Context, _ *params.Run, request *http.
 			return nil, fmt.Errorf("push event contains no commits under 'changes'; cannot proceed")
 		}
 
+		if len(e.Commits) == 0 {
+			return nil, fmt.Errorf("push event contains no commits; cannot proceed")
+		}
+
 		processedEvent.SHA = e.Changes[0].ToHash
 		processedEvent.URL = e.Repository.Links.Self[0].Href
 		processedEvent.BaseBranch = e.Changes[0].RefID

pkg/provider/bitbucketdatacenter/parse_payload_test.go

@@ -611,16 +611,23 @@ func TestParsePayload(t *testing.T) {
 		{
 			name:         "good/push",
 			eventType:    "repo:refs_changed",
-			payloadEvent: bbv1test.MakePushEvent(ev1, []types.PushRequestEventChange{{ToHash: ev1.SHA, RefID: "base"}}),
+			payloadEvent: bbv1test.MakePushEvent(ev1, []types.PushRequestEventChange{{ToHash: ev1.SHA, RefID: "base"}}, []types.Commit{{ID: ev1.SHA}}),
 			expEvent:     ev1,
 		},
 		{
 			name:          "bad/changes are empty in push",
 			eventType:     "repo:refs_changed",
-			payloadEvent:  bbv1test.MakePushEvent(ev1, []types.PushRequestEventChange{}),
+			payloadEvent:  bbv1test.MakePushEvent(ev1, []types.PushRequestEventChange{}, []types.Commit{}),
 			expEvent:      ev1,
 			wantErrSubstr: "push event contains no commits under 'changes'; cannot proceed",
 		},
+		{
+			name:          "bad/commits are empty in push",
+			eventType:     "repo:refs_changed",
+			payloadEvent:  bbv1test.MakePushEvent(ev1, []types.PushRequestEventChange{{ToHash: ev1.SHA, RefID: "base"}}, []types.Commit{}),
+			expEvent:      ev1,
+			wantErrSubstr: "push event contains no commits; cannot proceed",
+		},
 		{
 			name:         "good/comment ok-to-test",
 			eventType:    "pr:comment:added",

pkg/provider/bitbucketdatacenter/test/test.go

@@ -338,7 +338,7 @@ func MakePREvent(event *info.Event, comment string) *types.PullRequestEvent {
 	return pr
 }
 
-func MakePushEvent(event *info.Event, changes []types.PushRequestEventChange) *types.PushRequestEvent {
+func MakePushEvent(event *info.Event, changes []types.PushRequestEventChange, commits []types.Commit) *types.PushRequestEvent {
 	iii, _ := strconv.Atoi(event.AccountID)
 
 	return &types.PushRequestEvent{
@@ -366,5 +366,6 @@ func MakePushEvent(event *info.Event, changes []types.PushRequestEventChange) *t
 			},
 		},
 		Changes: changes,
+		Commits: commits,
 	}
 }