-
Notifications
You must be signed in to change notification settings - Fork 85
Why expired connections in thin pool are force closed? #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The main reason is that simply disconnecting the socket is guaranteed whereas sending the LogOff request may result in a hang -- which could impact the pool negatively. What do you mean by "expired connections"? When using a pool the general concept is that which connection is used is immaterial and the pool should be able to substitute connections or rebuild them at will. |
"expired connections" are idle connections in pool closed after timeout, set by so named parameter in pool constructor. |
@golubovai what exactly does your app rely on the logoff trigger to do? From the app's point of view, the connection was no longer needed, or usable, when the app released it back to the pool. What do you gain from some, unknown time later running a trigger? @anthony-tuininga we should revisit Thin/Thick behavior with the OCI team. |
This issue has been automatically marked as inactive because it has not been updated recently. It will be closed if no further activity occurs. Thank you for your contributions. |
database maintenance not being sent when using connection pools with asyncio; pooled connections that are no longer needed are now closed normally if possible instead of simply having the socket disconnected (#393).
I have pushed a patch that corrects this issue and have initated a build from which you can download pre-built development wheels once it completes. You can also build from source if you prefer. If you can test your scenario and confirm the patch works as expected, that would be appreciated! |
Hello! Force close of expired connections from pool prevent normal completion and execution of logoff triggers. Why are they force closed instead of normal close?
The text was updated successfully, but these errors were encountered: