From 8c5f1132c76c3a814d556b27b4060f1d3056c0af Mon Sep 17 00:00:00 2001
From: Lukasz <lukasz.rohde@gmail.com>
Date: Mon, 29 May 2023 15:05:54 +0200
Subject: [PATCH] [metadata-service]: move database migration script to a
 dedicated file

---
 modules/metadata-service/.gitignore          |  1 -
 modules/metadata-service/db_migrate/index.py | 20 +++++++++++++++
 modules/metadata-service/lambda.tf           | 27 --------------------
 modules/metadata-service/locals.tf           |  2 +-
 4 files changed, 21 insertions(+), 29 deletions(-)
 create mode 100644 modules/metadata-service/db_migrate/index.py

diff --git a/modules/metadata-service/.gitignore b/modules/metadata-service/.gitignore
index 3c201c8..f25e6d6 100644
--- a/modules/metadata-service/.gitignore
+++ b/modules/metadata-service/.gitignore
@@ -1,2 +1 @@
-index.py
 db_migrate_lambda.zip
diff --git a/modules/metadata-service/db_migrate/index.py b/modules/metadata-service/db_migrate/index.py
new file mode 100644
index 0000000..5ad55c0
--- /dev/null
+++ b/modules/metadata-service/db_migrate/index.py
@@ -0,0 +1,20 @@
+import os, json
+from urllib import request
+
+def handler(event, context):
+  response = {}
+  status_endpoint = "{}/db_schema_status".format(os.environ.get('MD_LB_ADDRESS'))
+  upgrade_endpoint = "{}/upgrade".format(os.environ.get('MD_LB_ADDRESS'))
+
+  with request.urlopen(status_endpoint) as status:
+    response['init-status'] = json.loads(status.read())
+
+  upgrade_patch = request.Request(upgrade_endpoint, method='PATCH')
+  with request.urlopen(upgrade_patch) as upgrade:
+    response['upgrade-result'] = upgrade.read().decode()
+
+  with request.urlopen(status_endpoint) as status:
+    response['final-status'] = json.loads(status.read())
+
+  print(response)
+  return(response)
diff --git a/modules/metadata-service/lambda.tf b/modules/metadata-service/lambda.tf
index e4375fc..5cc10dd 100644
--- a/modules/metadata-service/lambda.tf
+++ b/modules/metadata-service/lambda.tf
@@ -78,38 +78,11 @@ resource "aws_iam_role_policy" "grant_lambda_ecs_vpc" {
   policy = data.aws_iam_policy_document.lambda_ecs_task_execute_policy_vpc.json
 }
 
-resource "local_file" "db_migrate_lambda" {
-  content  = <<EOF
-import os, json
-from urllib import request
-
-def handler(event, context):
-  response = {}
-  status_endpoint = "{}/db_schema_status".format(os.environ.get('MD_LB_ADDRESS'))
-  upgrade_endpoint = "{}/upgrade".format(os.environ.get('MD_LB_ADDRESS'))
-
-  with request.urlopen(status_endpoint) as status:
-    response['init-status'] = json.loads(status.read())
-
-  upgrade_patch = request.Request(upgrade_endpoint, method='PATCH')
-  with request.urlopen(upgrade_patch) as upgrade:
-    response['upgrade-result'] = upgrade.read().decode()
-
-  with request.urlopen(status_endpoint) as status:
-    response['final-status'] = json.loads(status.read())
-
-  print(response)
-  return(response)
-EOF
-  filename = local.db_migrate_lambda_source_file
-}
-
 data "archive_file" "db_migrate_lambda" {
   type             = "zip"
   source_file      = local.db_migrate_lambda_source_file
   output_file_mode = "0666"
   output_path      = local.db_migrate_lambda_zip_file
-  depends_on       = [local_file.db_migrate_lambda]
 }
 
 resource "aws_lambda_function" "db_migrate_lambda" {
diff --git a/modules/metadata-service/locals.tf b/modules/metadata-service/locals.tf
index 75fe8b9..356a1b9 100644
--- a/modules/metadata-service/locals.tf
+++ b/modules/metadata-service/locals.tf
@@ -22,7 +22,7 @@ locals {
   api_gateway_stage_name                  = "api"
   api_gateway_usage_plan_name             = "${var.resource_prefix}usage-plan${var.resource_suffix}"
 
-  db_migrate_lambda_source_file = "${path.module}/index.py"
+  db_migrate_lambda_source_file = "${path.module}/db_migrate/index.py"
   db_migrate_lambda_zip_file    = "${path.module}/db_migrate_lambda.zip"
   db_migrate_lambda_name        = "${var.resource_prefix}db_migrate${var.resource_suffix}"
   lambda_ecs_execute_role_name  = "${var.resource_prefix}lambda_ecs_execute${var.resource_suffix}"