Fix property ignoreUnusedValuesWhenOnlyKeysAreUsedInForeach

Spilky · Spilky · commit 408797453c22 · 2022-04-22T09:37:27.000+02:00
- v releasu v7.0.19 slevomat/coding-standard došlo ke změně používání property ignoreUnusedValuesWhenOnlyKeysAreUsedInForeach, která nyní musí být boolean (viz: slevomat/coding-standard@78d5c13#diff-cab409323a53ecb0e91f7121aed69b589d5a85274a4a7541033cc235db9ca2c2) - před touto úpravou se vyhazovala chyba "Fatal error: Uncaught TypeError: SlevomatCodingStandard\Sniffs\Variables\UnusedVariableSniff::isValueInForeachAndErrorIsIgnored(): Return value must be of type bool, string returned in .../vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/Variables/UnusedVariableSniff.php:528"
diff --git a/src/PeckaCodingStandard/ruleset.xml b/src/PeckaCodingStandard/ruleset.xml
@@ -87,7 +87,7 @@
 	<!-- Variables -->
 	<rule ref="SlevomatCodingStandard.Variables.UnusedVariable">
 		<properties>
-			<property name="ignoreUnusedValuesWhenOnlyKeysAreUsedInForeach" value="1" />
+			<property name="ignoreUnusedValuesWhenOnlyKeysAreUsedInForeach" value="true" />
 		</properties>
 	</rule>
 </ruleset>
diff --git a/tests/Success/Variables/UnusedVariable.php b/tests/Success/Variables/UnusedVariable.php
@@ -5,5 +5,5 @@
 echo $hello;
 
 foreach ([] as $k => $v) {
-	echo $v;
+	echo $k;
 }

Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,5 @@`
`5`	`5`	`echo $hello;`
`6`	`6`
`7`	`7`	`foreach ([] as $k => $v) {`
`8`		`- echo $v;`
	`8`	`+ echo $k;`
`9`	`9`	`}`