Merge pull request #152 from danrot/versioning

removed wrong check from value converter

Author: dbu

composer.json

@@ -31,6 +31,9 @@
         "phpcr/phpcr": "~2.1.0",
         "symfony/console": "2.*,>=2.0.5"
     },
+    "conflict": {
+        "jackalope/jackalope-jackrabbit": "<1.2.1"
+    },
     "autoload": {
         "psr-0": {
             "PHPCR\\Util": "src"

src/PHPCR/Util/ValueConverter.php

@@ -130,11 +130,6 @@ public function convertType($value, $type, $srctype = PropertyType::UNDEFINED)
             && $value instanceof NodeInterface
         ) {
             /** @var $value NodeInterface */
-            // In Jackrabbit a new node cannot be referenced until it has been persisted
-            // See: https://issues.apache.org/jira/browse/JCR-1614
-            if ($value->isNew()) {
-                throw new ValueFormatException('Node ' . $value->getPath() . ' must be persisted before being referenceable');
-            }
             if (! $value->isNodeType('mix:referenceable')) {
                 throw new ValueFormatException('Node ' . $value->getPath() . ' is not referenceable');
             }

tests/PHPCR/Tests/Util/ValueConverterTest.php

@@ -387,7 +387,7 @@ public function testConvertNewNode()
     {
         $nodemock = $this->getMock('PHPCR\Tests\Stubs\MockNode');
         $nodemock
-            ->expects($this->once())
+            ->expects($this->never())
             ->method('isNew')
             ->will($this->returnValue(true))
         ;
@@ -400,7 +400,7 @@ public function testConvertNonrefNode()
     {
         $nodemock = $this->getMock('PHPCR\Tests\Stubs\MockNode');
         $nodemock
-            ->expects($this->once())
+            ->expects($this->never())
             ->method('isNew')
             ->will($this->returnValue(false))
         ;