Add missing HasHolds property to Get-PnPTenantSite cmdlet output (#4976)

* Initial plan

* Initial investigation: Found HasHolds property in SiteProperties

Co-authored-by: gautamdsheth <[email protected]>

* Add HasHolds property to SPOSite model for Get-PnPTenantSite cmdlet

Co-authored-by: gautamdsheth <[email protected]>

* Clean up duplicate test methods and finalize HasHolds property implementation

Co-authored-by: gautamdsheth <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: gautamdsheth <[email protected]>

Author: Copilot

src/Commands/Model/SPOSite.cs

@@ -90,6 +90,7 @@ public class SPOSite
         public bool IsGroupOwnerSiteAdmin { get; set; }
         public bool ListsShowHeaderAndNavigation { get; set; }
         public int LockReason { get; set; }
+        public bool HasHolds { get; set; }
         public int MajorVersionLimit { get; set; }
         public int MajorWithMinorVersionsLimit { get; set; }
         public bool RestrictedAccessControl { get; set; }
@@ -186,6 +187,7 @@ public SPOSite(SiteProperties props, bool? disableSharingForNonOwnersStatus)
             IsGroupOwnerSiteAdmin = props.IsGroupOwnerSiteAdmin;
             ListsShowHeaderAndNavigation = props.ListsShowHeaderAndNavigation;
             LockReason = props.LockReason;
+            HasHolds = props.HasHolds;
             MajorVersionLimit = props.MajorVersionLimit;
             MajorWithMinorVersionsLimit = props.MajorWithMinorVersionsLimit;
             RestrictedAccessControl = props.RestrictedAccessControl;

src/Commands/Utilities/ListItemHelper.cs

@@ -571,7 +571,7 @@ public static Dictionary<string, object> GetFieldValues(PnP.Core.Model.SharePoin
                                 if (choices is string)
                                 {
                                     // Handle comma or semicolon separated string
-                                    itemValue = string.Join(";#", ((string)choices).Split([',', ';'], StringSplitOptions.RemoveEmptyEntries).Select(c => c.Trim()));
+                                    itemValue = string.Join(";#", ((string)choices).Split(new char[] { ',', ';' }, StringSplitOptions.RemoveEmptyEntries).Select(c => c.Trim()));
                                 }
                                 else if (choices is Array)
                                 {

src/Tests/Admin/GetPnPTenantSiteTests.cs

@@ -89,6 +89,17 @@ public void GetPnPTenantSiteTest()
                 Assert.IsNotNull(results);
             }
         }
+
+        [TestMethod]
+        public void SPOSiteModelHasHoldsPropertyTest()
+        {
+            // Test that the SPOSite model has the HasHolds property
+            var spoSiteType = typeof(PnP.PowerShell.Commands.Model.SPOSite);
+            var hasHoldsProperty = spoSiteType.GetProperty("HasHolds");
+            
+            Assert.IsNotNull(hasHoldsProperty, "HasHolds property should exist on SPOSite model");
+            Assert.AreEqual(typeof(bool), hasHoldsProperty.PropertyType, "HasHolds property should be of type bool");
+        }
         #endregion
     }
 }