Merge branch 'master' into named-pipes-OTA-SU

Author: r-recchia

.github/actions/checkout-submodules/action.yaml

@@ -14,6 +14,6 @@ runs:
     - uses: Wandalen/[email protected]
       name: Checkout submodules
       with:
-        command: scripts/checkout_submodules.py --allow-changing-global-git-config --shallow --jobs 4 --platform ${{ inputs.platform }} ${{ inputs.extra-parameters }}
+        command: scripts/checkout_submodules.py --allow-changing-global-git-config --shallow --platform ${{ inputs.platform }} ${{ inputs.extra-parameters }}
         attempt_limit: 3
         attempt_delay: 2000

.github/actions/delete-cache/action.yml

@@ -0,0 +1,41 @@
+name: 'Delete Cache'
+description: 'Deletes a GitHub Actions cache by key using the GitHub API'
+inputs:
+  cache-key:
+    required: true
+    description: 'The cache key to delete'
+  github-token:
+    required: true
+    description: 'GitHub token for API authentication'
+runs:
+  using: "composite"
+  steps:
+    - name: Delete cache
+      uses: actions/github-script@v7
+      env:
+        CACHE_KEY: ${{ inputs.cache-key }}
+      with:
+        github-token: ${{ inputs.github-token }}
+        script: |
+          const owner = context.repo.owner;
+          const repo = context.repo.repo;
+          const key = process.env.CACHE_KEY;
+          const ref = context.ref;
+          
+          core.info(`Attempting to delete cache: ${key}`);
+          
+          try {
+            await github.rest.actions.deleteActionsCacheByKey({
+              owner: owner,
+              repo: repo,
+              key: key,
+              ref: ref
+            });
+            core.info(`Successfully deleted cache`);
+          } catch (e) {
+            if (e.status === 404) {
+              core.info(`Cache not found (first run or already deleted)`);
+            } else {
+              core.warning(`Failed to delete cache: ${e.message}`);
+            }
+          }

.github/actions/setup-ccache/action.yml

@@ -23,16 +23,23 @@ runs:
   using: "composite"
   steps:
     - name: Configure ccache
-      shell: bash
-      run: |
-        mkdir -p .ccache
-        echo "CCACHE_BASEDIR=${{ github.workspace }}" >> $GITHUB_ENV
-        echo "CCACHE_SLOPPINESS=time_macros" >> $GITHUB_ENV
-        echo "CCACHE_DIR=${{ github.workspace }}/.ccache" >> $GITHUB_ENV
-        echo "CCACHE_COMPILERCHECK=content" >> $GITHUB_ENV
-        echo "CCACHE_MAXSIZE=5G" >> $GITHUB_ENV
-        echo "CCACHE_COMPRESS=1" >> $GITHUB_ENV
-        echo "CCACHE_COMPRESSLEVEL=6" >> $GITHUB_ENV
+      uses: pyTooling/Actions/[email protected]
+      with:
+        main: |
+          mkdir -p .ccache
+          echo "CCACHE_NOHASHDIR=1" >> $GITHUB_ENV
+          echo "CCACHE_BASEDIR=${{ github.workspace }}" >> $GITHUB_ENV
+          echo "CCACHE_NODIRECT=1" >> $GITHUB_ENV
+          echo "CCACHE_PREFIX_CPP=${{ github.workspace }}/scripts/helpers/ccache-prefix-cpp.sh" >> $GITHUB_ENV
+          echo "CCACHE_SLOPPINESS=time_macros" >> $GITHUB_ENV
+          echo "CCACHE_DIR=${{ github.workspace }}/.ccache" >> $GITHUB_ENV
+          echo "CCACHE_COMPILERCHECK=content" >> $GITHUB_ENV
+          echo "CCACHE_MAXSIZE=5G" >> $GITHUB_ENV
+          echo "CCACHE_COMPRESS=1" >> $GITHUB_ENV
+          echo "CCACHE_COMPRESSLEVEL=6" >> $GITHUB_ENV
+          echo "CHIP_PW_COMMAND_LAUNCHER=ccache" >> $GITHUB_ENV
+        post: |
+          ccache --show-stats
     - name: Optionally disable ccache
       if: ${{ inputs.disable == 'true' }}
       shell: bash
@@ -42,14 +49,11 @@ runs:
       id: cache-vars
       shell: bash
       run: |
-        CACHE_WEEK=$(date +%G-%V)
-        echo "CACHE_WEEK=${CACHE_WEEK}" >> "$GITHUB_ENV"
-
         CACHE_SUFFIX="${{ inputs.cache-suffix }}"
         if [ -n "$CACHE_SUFFIX" ]; then
-          CCACHE_KEY="ccache-${{ runner.os }}-${{ inputs.build-variant }}-w${CACHE_WEEK}-${CACHE_SUFFIX}"
+          CCACHE_KEY="ccache-${{ runner.os }}-${{ inputs.build-variant }}-${CACHE_SUFFIX}"
         else
-          CCACHE_KEY="ccache-${{ runner.os }}-${{ inputs.build-variant }}-w${CACHE_WEEK}"
+          CCACHE_KEY="ccache-${{ runner.os }}-${{ inputs.build-variant }}"
         fi
         echo "CCACHE_KEY=${CCACHE_KEY}" >> "$GITHUB_ENV"
         echo "cache_key=${CCACHE_KEY}" >> "$GITHUB_OUTPUT"

.github/dependabot.yml

@@ -24,6 +24,7 @@ updates:
       - dependency-name: "third_party/mbedtls/repo"
       - dependency-name: "third_party/openthread/repo"
 
+      - dependency-name: "third_party/amazon-kinesis-video-streams-webrtc-sdk-c/repo"
       - dependency-name: "third_party/ameba/repo"
       - dependency-name: "third_party/android_deps/repo"
       - dependency-name: "third_party/asr/repo"

.github/workflows/bloat_check.yaml

@@ -34,7 +34,7 @@ jobs:
         runs-on: ubuntu-latest
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
 
         steps:
             - name: Checkout

.github/workflows/build.yaml

@@ -43,7 +43,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             volumes:
                 - "/:/runner-root-volume"
                 - "/tmp/log_output:/tmp/test_logs"
@@ -72,7 +72,7 @@ jobs:
                 platform: linux
             - name: Initialize CodeQL
               if: ${{ inputs.run-codeql  }}
-              uses: github/codeql-action/init@v3
+              uses: github/codeql-action/init@v4
               with:
                   languages: "cpp"
                   queries: security-extended, security-and-quality
@@ -120,7 +120,7 @@ jobs:
               if: inputs.run-codeql != true
               run: scripts/run_in_build_env.sh "ninja -C ./out"
             - name: Uploading core files
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v5
               if: ${{ failure() && !env.ACT }}
               with:
                   name: crash-core-linux-gcc-debug
@@ -138,7 +138,7 @@ jobs:
             # If re-enabling, some subset of this should be picked
             #
             # - name: Uploading objdir for debugging
-            #   uses: actions/upload-artifact@v4
+            #   uses: actions/upload-artifact@v5
             #   if: ${{ failure() && !env.ACT }}
             #   with:
             #       name: crash-objdir-linux-gcc-debug
@@ -153,7 +153,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]' && inputs.run-codeql != true
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             volumes:
                 - "/:/runner-root-volume"
                 - "/tmp/log_output:/tmp/test_logs"
@@ -187,7 +187,7 @@ jobs:
             # deactivate until a better workaround is found
             # - name: Initialize CodeQL
             #   if: ${{ inputs.run-codeql  }}
-            #   uses: github/codeql-action/init@v3
+            #   uses: github/codeql-action/init@v4
             #   with:
             #       languages: "cpp"
             - name: Setup and Build Simulated Device
@@ -235,11 +235,6 @@ jobs:
             - name: Find changed files
               id: changed-files
               uses: tj-actions/changed-files@v47
-              with:
-                # Exclude all files under "third_party/"
-                files-ignore: |
-                  third_party/
-
             - name: Clang-tidy validation
               # NOTE: clang-tidy crashes on CodegenDataModel_Write due to Nullable/std::optional check.
               #       See https://github.com/llvm/llvm-project/issues/97426
@@ -303,7 +298,7 @@ jobs:
             #     language: cpp
 
             - name: Uploading core files
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v5
               if: ${{ failure() && !env.ACT }}
               with:
                   name: crash-core-linux
@@ -316,7 +311,7 @@ jobs:
             # If re-enabling, some subset of this should be picked
             #
             # - name: Uploading objdir for debugging
-            #   uses: actions/upload-artifact@v4
+            #   uses: actions/upload-artifact@v5
             #   if: ${{ failure() && !env.ACT }}
             #   with:
             #       name: crash-objdir-linux
@@ -331,7 +326,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]' && inputs.run-codeql != true
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             volumes:
                 - "/:/runner-root-volume"
                 - "/tmp/log_output:/tmp/test_logs"
@@ -394,7 +389,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]' && inputs.run-codeql != true
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             volumes:
                 - "/:/runner-root-volume"
                 - "/tmp/log_output:/tmp/test_logs"
@@ -442,7 +437,7 @@ jobs:
             #  Build on Darwin + CodeQL often takes 6 hours (which is more than the maximum allowed by GitHub Runners), Deactivate it until we can investigate this
             # - name: Initialize CodeQL
             #   if: ${{ inputs.run-codeql  }}
-            #   uses: github/codeql-action/init@v3
+            #   uses: github/codeql-action/init@v4
             #   with:
             #       languages: "cpp"
 
@@ -492,7 +487,7 @@ jobs:
                        check \
                     "
             - name: Uploading diagnostic logs
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v5
               if: ${{ failure() && !env.ACT }}
               with:
                   name: crash-log-darwin
@@ -518,7 +513,7 @@ jobs:
         runs-on: ubuntu-latest
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             options: --privileged --sysctl "net.ipv6.conf.all.disable_ipv6=0
                 net.ipv4.conf.all.forwarding=0 net.ipv6.conf.all.forwarding=0"
 

.github/workflows/chef.yaml

@@ -37,7 +37,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             options: --user root
 
         steps:
@@ -58,7 +58,7 @@ jobs:
         timeout-minutes: 90
         runs-on: ubuntu-latest
         container:
-            image: ghcr.io/project-chip/chip-build:169
+            image: ghcr.io/project-chip/chip-build:174
             options: >-
                 --privileged
                 --sysctl net.ipv6.conf.all.disable_ipv6=0
@@ -96,7 +96,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build-esp32:168
+            image: ghcr.io/project-chip/chip-build-esp32:174
             options: --user root
 
         steps:
@@ -106,6 +106,16 @@ jobs:
               uses: ./.github/actions/checkout-submodules-and-bootstrap
               with:
                 platform: esp32
+
+            # We cannot add esp-idf-kconfig==2.5.0 to rquirements.txt because it
+            # will break the nuttx workflow which requires the older version of
+            # the kconfiglib and esp-idf-kconfig==2.5.0 installs newer version
+            # so, install it in in the virtual environment here
+            - name: Install esp-idf-kconfig
+              run: |
+                  ./scripts/run_in_build_env.sh \
+                    "pip install esp-idf-kconfig==2.5.0"
+
             - name: CI Examples ESP32
               shell: bash
               run: |
@@ -117,7 +127,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build-nrf-platform:169
+            image: ghcr.io/project-chip/chip-build-nrf-platform:174
             options: --user root
 
         steps:
@@ -138,7 +148,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build-telink:168
+            image: ghcr.io/project-chip/chip-build-telink:174
             options: --user root
 
         steps:

.github/workflows/cirque.yaml

@@ -130,7 +130,7 @@ jobs:
                    
 
             - name: Uploading Binaries
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v5
               if: ${{ always() && !env.ACT }}
               with:
                   name: cirque_log-${{steps.outsuffix.outputs.value}}-logs

.github/workflows/darwin-tests.yaml

@@ -145,27 +145,27 @@ jobs:
              --ota-candidate-file /tmp/otaCandidateJSON \
           "
       - name: Uploading core files
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         if: ${{ failure() && !env.ACT }}
         with:
           name: crash-core-darwin-${{ matrix.build_variant }}
           path: /cores/
           # Cores are big; don't hold on to them too long.
           retention-days: 5
       - name: Uploading diagnostic logs
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         if: ${{ failure() && !env.ACT }}
         with:
           name: crash-log-darwin-${{ matrix.build_variant }}
           path: ~/Library/Logs/DiagnosticReports/
       - name: Uploading framework build log
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         if: ${{ failure() && !env.ACT }}
         with:
           name: framework-build-log-darwin-${BUILD_VARIANT_FRAMEWORK_TOOL}
           path: out/darwin-${{matrix.arch}}-darwin-framework-tool-${BUILD_VARIANT_FRAMEWORK_TOOL}/darwin_framework_build.log
       - name: Uploading objdir for debugging
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         if: ${{ failure() && !env.ACT }}
         with:
           name: crash-objdir-darwin-${{ matrix.build_variant }}

.github/workflows/darwin.yaml

@@ -132,7 +132,7 @@ jobs:
                   mkdir -p /tmp/darwin/framework-tests
                   find ~/Library/Developer/Xcode/DerivedData /Library/Logs/DiagnosticReports -name '*.ips' -print0 | xargs -0 -J % cp % /tmp/darwin/framework-tests
             - name: Uploading log files
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v5
               if: failure() && !env.ACT
               with:
                   name: darwin-framework-test-logs-${{ matrix.options.flavor }}