[Closure] Adding matter closure specific attribute callback (#41592)

* Adding matter closure specific attribute callback when markdirty is called

* Restyled by whitespace

* Adding attribute update callback for closure dimension

* Restyled by whitespace

* add mock in unit tests

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>

Author: sabollim-silabs

examples/closure-app/linux/BUILD.gn

@@ -35,6 +35,7 @@ executable("closure-app") {
     "${chip_root}/examples/closure-app/closure-common/src/ClosureControlEndpoint.cpp",
     "${chip_root}/examples/closure-app/closure-common/src/ClosureDimensionEndpoint.cpp",
     "ClosureManager.cpp",
+    "DataModelCallbacks.cpp",
     "include/CHIPProjectAppConfig.h",
     "main.cpp",
   ]

examples/closure-app/linux/DataModelCallbacks.cpp

@@ -0,0 +1,35 @@
+/*
+ *
+ *    Copyright (c) 2025 Project CHIP Authors
+ *    All rights reserved.
+ *
+ *    Licensed under the Apache License, Version 2.0 (the "License");
+ *    you may not use this file except in compliance with the License.
+ *    You may obtain a copy of the License at
+ *
+ *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
+ */
+
+#include <app-common/zap-generated/callback.h>
+#include <app/ConcreteAttributePath.h>
+#include <lib/support/logging/CHIPLogging.h>
+
+using namespace chip;
+using namespace chip::app;
+
+/* Forwards all attributes changes */
+void MatterClosureControlClusterServerAttributeChangedCallback(const app::ConcreteAttributePath & attributePath)
+{
+    ChipLogProgress(Zcl, "Closure Control cluster ID: " ChipLogFormatMEI, ChipLogValueMEI(attributePath.mAttributeId));
+}
+
+void MatterClosureDimensionClusterServerAttributeChangedCallback(const app::ConcreteAttributePath & attributePath)
+{
+    ChipLogProgress(Zcl, "Closure Dimension cluster ID: " ChipLogFormatMEI, ChipLogValueMEI(attributePath.mAttributeId));
+}

examples/closure-app/silabs/src/DataModelCallbacks.cpp

@@ -52,12 +52,10 @@ void MatterPostAttributeChangeCallback(const app::ConcreteAttributePath & attrib
 /* Forwards all attributes changes */
 void MatterClosureControlClusterServerAttributeChangedCallback(const app::ConcreteAttributePath & attributePath)
 {
-    ChipLogProgress(Zcl, "Closure cluster ID: " ChipLogFormatMEI, ChipLogValueMEI(attributePath.mAttributeId));
-    // Attribute changes handling will be done in the next phase.
+    ChipLogProgress(Zcl, "Closure Control cluster ID: " ChipLogFormatMEI, ChipLogValueMEI(attributePath.mAttributeId));
 }
 
 void MatterClosureDimensionClusterServerAttributeChangedCallback(const app::ConcreteAttributePath & attributePath)
 {
-    ChipLogProgress(Zcl, "Closure cluster ID: " ChipLogFormatMEI, ChipLogValueMEI(attributePath.mAttributeId));
-    // Attribute changes handling will be done in the next phase.
+    ChipLogProgress(Zcl, "Closure Dimension cluster ID: " ChipLogFormatMEI, ChipLogValueMEI(attributePath.mAttributeId));
 }

src/app/clusters/closure-control-server/closure-control-cluster-matter-context.h

@@ -18,7 +18,9 @@
 
 #pragma once
 
+#include <app-common/zap-generated/callback.h>
 #include <app-common/zap-generated/ids/Clusters.h>
+#include <app/ConcreteAttributePath.h>
 #include <app/EventLogging.h>
 #include <app/reporting/reporting.h>
 #include <lib/core/CHIPError.h>
@@ -38,7 +40,13 @@ class MatterContext
     MatterContext(EndpointId endpointId) : mEndpointId(endpointId) {}
     virtual ~MatterContext() = default;
 
-    virtual void MarkDirty(AttributeId attributeId) { MatterReportingAttributeChangeCallback(mEndpointId, Id, attributeId); }
+    virtual void MarkDirty(AttributeId attributeId)
+    {
+        MatterReportingAttributeChangeCallback(mEndpointId, Id, attributeId);
+
+        ConcreteAttributePath attributePath(mEndpointId, Id, attributeId);
+        MatterClosureControlClusterServerAttributeChangedCallback(attributePath);
+    }
 
     template <typename EventType>
     CHIP_ERROR GenerateEvent(EventType event)

src/app/clusters/closure-dimension-server/closure-dimension-matter-context.cpp

@@ -17,8 +17,9 @@
  */
 
 #include "closure-dimension-matter-context.h"
-
+#include <app-common/zap-generated/callback.h>
 #include <app-common/zap-generated/ids/Clusters.h>
+#include <app/ConcreteAttributePath.h>
 #include <app/reporting/reporting.h>
 
 namespace chip {
@@ -29,6 +30,9 @@ namespace ClosureDimension {
 void MatterContext::MarkDirty(const AttributeId attributeId)
 {
     MatterReportingAttributeChangeCallback(mEndpoint, Id, attributeId);
+
+    ConcreteAttributePath attributePath(mEndpoint, Id, attributeId);
+    MatterClosureDimensionClusterServerAttributeChangedCallback(attributePath);
 }
 
 } // namespace ClosureDimension

src/app/tests/TestClosureControlClusterLogic.cpp

@@ -106,6 +106,13 @@ class TimerAndMockClock : public Clock::Internal::MockClock, public Layer
 } // namespace System
 } // namespace chip
 
+// Mock callback functions
+__attribute__((unused)) void
+MatterClosureControlClusterServerAttributeChangedCallback(const chip::app::ConcreteAttributePath & attributePath)
+{
+    // Mock implementation - no-op for tests
+}
+
 namespace {
 
 // These are globals because SetUpTestSuite is static which requires static variables

src/app/tests/TestClosureDimensionCluster.cpp

@@ -2427,3 +2427,10 @@ TEST_F(TestClosureDimensionClusterLogic, TestCurrentStateQuietReportingSpeedValu
 } // namespace Clusters
 } // namespace app
 } // namespace chip
+
+// Mock callback functions
+__attribute__((unused)) void
+MatterClosureDimensionClusterServerAttributeChangedCallback(const chip::app::ConcreteAttributePath & attributePath)
+{
+    // Mock implementation - no-op for tests
+}