Remove AttributeList from Device Layer

It was only used in a single place and probably didn't belong in the device layer
in the first place.  Use a Span instead for DeviceInforProvider::SetUserLabelList.

Also simplify DeviceInforProvider::ClearUserLabelList().

Author: ksperling-apple

src/BUILD.gn

@@ -83,7 +83,6 @@ if (chip_build_tests) {
       "${chip_root}/src/crypto/tests",
       "${chip_root}/src/data-model-providers/codedriven/endpoint/tests",
       "${chip_root}/src/inet/tests",
-      "${chip_root}/src/include/platform/tests",
       "${chip_root}/src/lib/address_resolve/tests",
       "${chip_root}/src/app/server-cluster/tests",
       "${chip_root}/src/lib/asn1/tests",

src/app/clusters/user-label-server/user-label-cluster.cpp

@@ -19,6 +19,8 @@
 #include <app/server/Server.h>
 #include <clusters/UserLabel/Metadata.h>
 
+#include <array>
+
 namespace chip::app::Clusters {
 
 using namespace UserLabel;
@@ -73,19 +75,6 @@ bool IsValidLabelEntry(const Structs::LabelStruct::Type & entry)
     return (entry.label.size() <= kMaxLabelSize) && (entry.value.size() <= kMaxValueSize);
 }
 
-bool IsValidLabelEntryList(const LabelList::TypeInfo::DecodableType & list)
-{
-    auto iter = list.begin();
-    while (iter.Next())
-    {
-        if (!IsValidLabelEntry(iter.GetValue()))
-        {
-            return false;
-        }
-    }
-    return true;
-}
-
 CHIP_ERROR WriteLabelList(const ConcreteDataAttributePath & path, AttributeValueDecoder & decoder)
 {
     DeviceLayer::DeviceInfoProvider * provider = DeviceLayer::GetDeviceInfoProvider();
@@ -96,20 +85,22 @@ CHIP_ERROR WriteLabelList(const ConcreteDataAttributePath & path, AttributeValue
 
     if (!path.IsListItemOperation())
     {
-        DeviceLayer::AttributeList<Structs::LabelStruct::Type, DeviceLayer::kMaxUserLabelListLength> labelList;
+        size_t numLabels = 0;
+        std::array<Structs::LabelStruct::Type, DeviceLayer::kMaxUserLabelListLength> labels;
         LabelList::TypeInfo::DecodableType decodablelist;
 
         ReturnErrorOnFailure(decoder.Decode(decodablelist));
-        VerifyOrReturnError(IsValidLabelEntryList(decodablelist), CHIP_IM_GLOBAL_STATUS(ConstraintError));
-
         auto iter = decodablelist.begin();
         while (iter.Next())
         {
-            ReturnErrorOnFailure(labelList.add(iter.GetValue()));
+            auto & label = iter.GetValue();
+            VerifyOrReturnError(IsValidLabelEntry(label), CHIP_IM_GLOBAL_STATUS(ConstraintError));
+            VerifyOrReturnError(numLabels < labels.size(), CHIP_ERROR_NO_MEMORY);
+            labels[numLabels++] = label;
         }
         ReturnErrorOnFailure(iter.GetStatus());
 
-        return provider->SetUserLabelList(endpoint, labelList);
+        return provider->SetUserLabelList(endpoint, Span(labels.data(), numLabels));
     }
 
     if (path.mListOp == ConcreteDataAttributePath::ListOperation::AppendItem)

src/include/platform/AttributeList.h

@@ -24,7 +24,7 @@
 #include <app/util/basic-types.h>
 #include <lib/core/CHIPError.h>
 #include <lib/core/CHIPPersistentStorageDelegate.h>
-#include <platform/AttributeList.h>
+#include <lib/support/Span.h>
 
 namespace chip {
 namespace DeviceLayer {
@@ -101,7 +101,7 @@ class DeviceInfoProvider
      * @return CHIP_NO_ERROR on success.
      * @return CHIP_ERROR if an error occurs.
      */
-    CHIP_ERROR SetUserLabelList(EndpointId endpoint, const AttributeList<UserLabelType, kMaxUserLabelListLength> & labelList);
+    CHIP_ERROR SetUserLabelList(EndpointId endpoint, Span<const UserLabelType> labelList);
 
     /**
      * @brief Clears the user label list for a specified endpoint.

src/include/platform/DeviceInfoProvider.h

@@ -23,7 +23,6 @@
 
 #pragma once
 
-#include <platform/AttributeList.h>
 #include <platform/CHIPDeviceConfig.h>
 #include <platform/CHIPDeviceEvent.h>
 #include <system/PlatformEventSupport.h>