Skip to content

Commit 9359df4

Browse files
Stop the app before start. Needed to avoid port collissions for apps launched with --secure-device-port. Removed break in monitor_app_requestor to allow multiple restarts
1 parent 4edda3f commit 9359df4

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

scripts/tests/run_python_test.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -376,14 +376,13 @@ def monitor_app_restart_requests(
376376
os.unlink(restart_flag_file)
377377

378378
new_app_manager = AppProcessManager(app, app_args, app_ready_pattern, stream_output, app_stdin_pipe)
379-
new_app_manager.start()
379+
app_manager_ref[0].stop()
380380
with app_manager_lock:
381-
app_manager_ref[0].stop()
381+
new_app_manager.start()
382382
app_manager_ref[0] = new_app_manager
383383

384384
# After restart is complete, we can exit the monitor thread
385385
logging.info("App restart completed, monitor thread exiting")
386-
break
387386
else:
388387
time.sleep(0.5)
389388
except Exception as e:

0 commit comments

Comments
 (0)