Skip to content

Commit d346b3f

Browse files
committed
Fix zap issue
1 parent 3515c62 commit d346b3f

File tree

3 files changed

+17
-43
lines changed

3 files changed

+17
-43
lines changed

examples/closure-app/closure-common/closure-app.matter

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2420,12 +2420,12 @@ endpoint 1 {
24202420

24212421

24222422
server cluster Identify {
2423-
ram attribute identifyTime default = 0x0;
2424-
ram attribute identifyType default = 0x00;
2423+
callback attribute identifyTime;
2424+
callback attribute identifyType;
24252425
callback attribute generatedCommandList;
24262426
callback attribute acceptedCommandList;
24272427
callback attribute attributeList;
2428-
ram attribute featureMap default = 0;
2428+
callback attribute featureMap;
24292429
callback attribute clusterRevision;
24302430

24312431
handle command Identify;

examples/closure-app/silabs/data_model/closure-thread-app.matter

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -435,12 +435,7 @@ cluster Descriptor = 29 {
435435
and enforce Access Control for the Node's endpoints and their associated
436436
cluster instances. */
437437
cluster AccessControl = 31 {
438-
revision 3;
439-
440-
enum AccessControlAuxiliaryTypeEnum : enum8 {
441-
kSystem = 0;
442-
kGroupcast = 1;
443-
}
438+
revision 2;
444439

445440
enum AccessControlEntryAuthModeEnum : enum8 {
446441
kPASE = 1 [spec_name = "PASE"];
@@ -472,7 +467,6 @@ cluster AccessControl = 31 {
472467
bitmap Feature : bitmap32 {
473468
kExtension = 0x1;
474469
kManagedDevice = 0x2;
475-
kAuxiliary = 0x4;
476470
}
477471

478472
struct AccessRestrictionStruct {
@@ -504,7 +498,6 @@ cluster AccessControl = 31 {
504498
fabric_sensitive AccessControlEntryAuthModeEnum authMode = 2;
505499
nullable fabric_sensitive int64u subjects[] = 3;
506500
nullable fabric_sensitive AccessControlTargetStruct targets[] = 4;
507-
optional fabric_sensitive AccessControlAuxiliaryTypeEnum auxiliaryType = 5;
508501
fabric_idx fabricIndex = 254;
509502
}
510503

@@ -536,19 +529,13 @@ cluster AccessControl = 31 {
536529
fabric_idx fabricIndex = 254;
537530
}
538531

539-
fabric_sensitive info event access(read: administer) AuxiliaryAccessUpdated = 3 {
540-
nullable node_id adminNodeID = 0;
541-
fabric_idx fabricIndex = 254;
542-
}
543-
544532
attribute access(read: administer, write: administer) AccessControlEntryStruct acl[] = 0;
545533
attribute access(read: administer, write: administer) optional AccessControlExtensionStruct extension[] = 1;
546534
readonly attribute int16u subjectsPerAccessControlEntry = 2;
547535
readonly attribute int16u targetsPerAccessControlEntry = 3;
548536
readonly attribute int16u accessControlEntriesPerFabric = 4;
549537
readonly attribute optional CommissioningAccessRestrictionEntryStruct commissioningARL[] = 5;
550538
readonly attribute optional AccessRestrictionEntryStruct arl[] = 6;
551-
readonly attribute access(read: administer) optional AccessControlEntryStruct auxiliaryACL[] = 7;
552539
readonly attribute command_id generatedCommandList[] = 65528;
553540
readonly attribute command_id acceptedCommandList[] = 65529;
554541
readonly attribute attrib_id attributeList[] = 65531;
@@ -1732,12 +1719,12 @@ cluster IcdManagement = 70 {
17321719
int32u promisedActiveDuration = 0;
17331720
}
17341721

1735-
/** This command allows a client to register itself with the ICD to be notified when the device is available for communication. */
1722+
/** Register a client to the end device */
17361723
fabric command access(invoke: manage) RegisterClient(RegisterClientRequest): RegisterClientResponse = 0;
1737-
/** This command allows a client to unregister itself with the ICD. */
1724+
/** Unregister a client from an end device */
17381725
fabric command access(invoke: manage) UnregisterClient(UnregisterClientRequest): DefaultSuccess = 2;
1739-
/** This command allows a client to request that the server stays in active mode for at least a given time duration (in milliseconds) from when this command is received. */
1740-
command StayActiveRequest(StayActiveRequestRequest): StayActiveResponse = 3;
1726+
/** Request the end device to stay in Active Mode for an additional ActiveModeThreshold */
1727+
command access(invoke: manage) StayActiveRequest(StayActiveRequestRequest): StayActiveResponse = 3;
17411728
}
17421729

17431730
/** This cluster provides an interface for controlling a Closure. */
@@ -2258,8 +2245,8 @@ endpoint 0 {
22582245

22592246
server cluster UserLabel {
22602247
callback attribute labelList;
2261-
callback attribute featureMap;
2262-
callback attribute clusterRevision;
2248+
ram attribute featureMap default = 0;
2249+
ram attribute clusterRevision default = 1;
22632250
}
22642251

22652252
server cluster IcdManagement {

examples/closure-app/silabs/data_model/closure-wifi-app.matter

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -435,12 +435,7 @@ cluster Descriptor = 29 {
435435
and enforce Access Control for the Node's endpoints and their associated
436436
cluster instances. */
437437
cluster AccessControl = 31 {
438-
revision 3;
439-
440-
enum AccessControlAuxiliaryTypeEnum : enum8 {
441-
kSystem = 0;
442-
kGroupcast = 1;
443-
}
438+
revision 2;
444439

445440
enum AccessControlEntryAuthModeEnum : enum8 {
446441
kPASE = 1 [spec_name = "PASE"];
@@ -472,7 +467,6 @@ cluster AccessControl = 31 {
472467
bitmap Feature : bitmap32 {
473468
kExtension = 0x1;
474469
kManagedDevice = 0x2;
475-
kAuxiliary = 0x4;
476470
}
477471

478472
struct AccessRestrictionStruct {
@@ -504,7 +498,6 @@ cluster AccessControl = 31 {
504498
fabric_sensitive AccessControlEntryAuthModeEnum authMode = 2;
505499
nullable fabric_sensitive int64u subjects[] = 3;
506500
nullable fabric_sensitive AccessControlTargetStruct targets[] = 4;
507-
optional fabric_sensitive AccessControlAuxiliaryTypeEnum auxiliaryType = 5;
508501
fabric_idx fabricIndex = 254;
509502
}
510503

@@ -536,19 +529,13 @@ cluster AccessControl = 31 {
536529
fabric_idx fabricIndex = 254;
537530
}
538531

539-
fabric_sensitive info event access(read: administer) AuxiliaryAccessUpdated = 3 {
540-
nullable node_id adminNodeID = 0;
541-
fabric_idx fabricIndex = 254;
542-
}
543-
544532
attribute access(read: administer, write: administer) AccessControlEntryStruct acl[] = 0;
545533
attribute access(read: administer, write: administer) optional AccessControlExtensionStruct extension[] = 1;
546534
readonly attribute int16u subjectsPerAccessControlEntry = 2;
547535
readonly attribute int16u targetsPerAccessControlEntry = 3;
548536
readonly attribute int16u accessControlEntriesPerFabric = 4;
549537
readonly attribute optional CommissioningAccessRestrictionEntryStruct commissioningARL[] = 5;
550538
readonly attribute optional AccessRestrictionEntryStruct arl[] = 6;
551-
readonly attribute access(read: administer) optional AccessControlEntryStruct auxiliaryACL[] = 7;
552539
readonly attribute command_id generatedCommandList[] = 65528;
553540
readonly attribute command_id acceptedCommandList[] = 65529;
554541
readonly attribute attrib_id attributeList[] = 65531;
@@ -1641,12 +1628,12 @@ cluster IcdManagement = 70 {
16411628
int32u promisedActiveDuration = 0;
16421629
}
16431630

1644-
/** This command allows a client to register itself with the ICD to be notified when the device is available for communication. */
1631+
/** Register a client to the end device */
16451632
fabric command access(invoke: manage) RegisterClient(RegisterClientRequest): RegisterClientResponse = 0;
1646-
/** This command allows a client to unregister itself with the ICD. */
1633+
/** Unregister a client from an end device */
16471634
fabric command access(invoke: manage) UnregisterClient(UnregisterClientRequest): DefaultSuccess = 2;
1648-
/** This command allows a client to request that the server stays in active mode for at least a given time duration (in milliseconds) from when this command is received. */
1649-
command StayActiveRequest(StayActiveRequestRequest): StayActiveResponse = 3;
1635+
/** Request the end device to stay in Active Mode for an additional ActiveModeThreshold */
1636+
command access(invoke: manage) StayActiveRequest(StayActiveRequestRequest): StayActiveResponse = 3;
16501637
}
16511638

16521639
/** This cluster provides an interface for controlling a Closure. */
@@ -2120,8 +2107,8 @@ endpoint 0 {
21202107

21212108
server cluster UserLabel {
21222109
callback attribute labelList;
2123-
callback attribute featureMap;
2124-
callback attribute clusterRevision;
2110+
ram attribute featureMap default = 0;
2111+
ram attribute clusterRevision default = 1;
21252112
}
21262113

21272114
server cluster IcdManagement {

0 commit comments

Comments
 (0)