Move max size constants into the header and add more tests

Author: ksperling-apple

src/app/clusters/user-label-server/tests/TestUserLabelCluster.cpp

@@ -25,6 +25,7 @@
 #include <clusters/UserLabel/Enums.h>
 #include <clusters/UserLabel/Metadata.h>
 #include <clusters/UserLabel/Structs.h>
+#include <platform/DeviceInfoProvider.h>
 
 namespace {
 
@@ -35,21 +36,55 @@ using namespace chip::app::Clusters::UserLabel;
 using namespace chip::app::Clusters::UserLabel::Attributes;
 using namespace chip::Test;
 
+// Mock DeviceInfoProvider for testing
+class MockDeviceInfoProvider : public DeviceLayer::DeviceInfoProvider
+{
+public:
+    MockDeviceInfoProvider()           = default;
+    ~MockDeviceInfoProvider() override = default;
+
+    FixedLabelIterator * IterateFixedLabel(EndpointId endpoint) override { return nullptr; }
+    UserLabelIterator * IterateUserLabel(EndpointId endpoint) override { return nullptr; }
+    SupportedCalendarTypesIterator * IterateSupportedCalendarTypes() override { return nullptr; }
+    SupportedLocalesIterator * IterateSupportedLocales() override { return nullptr; }
+
+protected:
+    // Simple no-op implementations - we only need these to return success
+    // so that the cluster's validation logic can be tested
+    CHIP_ERROR SetUserLabelLength(EndpointId endpoint, size_t val) override { return CHIP_NO_ERROR; }
+    CHIP_ERROR GetUserLabelLength(EndpointId endpoint, size_t & val) override
+    {
+        val = 0;
+        return CHIP_NO_ERROR;
+    }
+    CHIP_ERROR SetUserLabelAt(EndpointId endpoint, size_t index, const UserLabelType & userLabel) override { return CHIP_NO_ERROR; }
+    CHIP_ERROR DeleteUserLabelAt(EndpointId endpoint, size_t index) override { return CHIP_NO_ERROR; }
+};
+
 struct TestUserLabelCluster : public ::testing::Test
 {
     static void SetUpTestSuite() { ASSERT_EQ(chip::Platform::MemoryInit(), CHIP_NO_ERROR); }
 
     static void TearDownTestSuite() { chip::Platform::MemoryShutdown(); }
 
-    void SetUp() override { ASSERT_EQ(userLabel.Startup(context), CHIP_NO_ERROR); }
+    void SetUp() override
+    {
+        DeviceLayer::SetDeviceInfoProvider(&mDeviceInfoProvider);
+        ASSERT_EQ(userLabel.Startup(context), CHIP_NO_ERROR);
+    }
 
-    void TearDown() override { userLabel.Shutdown(); }
+    void TearDown() override
+    {
+        userLabel.Shutdown();
+        DeviceLayer::SetDeviceInfoProvider(nullptr);
+    }
 
     TestUserLabelCluster() : context(testContext.Create()), userLabel(kRootEndpointId) {}
 
     chip::Test::TestServerClusterContext testContext;
     ServerClusterContext context;
     UserLabelCluster userLabel;
+    MockDeviceInfoProvider mDeviceInfoProvider;
 };
 
 } // namespace
@@ -83,3 +118,56 @@ TEST_F(TestUserLabelCluster, ReadAttributeTest)
         ASSERT_GT(it.GetValue().label.size(), 0u);
     }
 }
+
+TEST_F(TestUserLabelCluster, WriteValidLabelListTest)
+{
+    ClusterTester tester(userLabel);
+    Structs::LabelStruct::Type labels[] = {
+        { .label = "room"_span, .value = "bedroom 2"_span },
+        { .label = "orientation"_span, .value = "North"_span },
+    };
+    ASSERT_EQ(tester.WriteAttribute(LabelList::Id, DataModel::List(labels)), CHIP_NO_ERROR);
+}
+
+TEST_F(TestUserLabelCluster, WriteLabelWithLabelTooLongTest)
+{
+    ClusterTester tester(userLabel);
+    constexpr auto tooLongLabel = "this_label_is_way_too_long"_span;
+    static_assert(tooLongLabel.size() > UserLabelCluster::kMaxLabelSize);
+    Structs::LabelStruct::Type labels[] = {
+        { .label = tooLongLabel, .value = "value"_span },
+    };
+    ASSERT_EQ(tester.WriteAttribute(LabelList::Id, DataModel::List(labels)), CHIP_IM_GLOBAL_STATUS(ConstraintError));
+}
+
+TEST_F(TestUserLabelCluster, WriteLabelWithValueTooLongTest)
+{
+    ClusterTester tester(userLabel);
+    constexpr auto tooLongValue = "this_value_is_way_too_long"_span;
+    static_assert(tooLongValue.size() > UserLabelCluster::kMaxValueSize);
+    Structs::LabelStruct::Type labels[] = {
+        { .label = "room"_span, .value = tooLongValue },
+    };
+    ASSERT_EQ(tester.WriteAttribute(LabelList::Id, DataModel::List(labels)), CHIP_IM_GLOBAL_STATUS(ConstraintError));
+}
+
+TEST_F(TestUserLabelCluster, WriteEmptyLabelsTest)
+{
+    ClusterTester tester(userLabel);
+    Structs::LabelStruct::Type labels[] = {
+        { .label = ""_span, .value = ""_span }, // empty label and value are allowed per spec
+    };
+    ASSERT_EQ(tester.WriteAttribute(LabelList::Id, DataModel::List(labels)), CHIP_NO_ERROR);
+}
+
+TEST_F(TestUserLabelCluster, WriteMaxSizeLabelListTest)
+{
+    ClusterTester tester(userLabel);
+    std::array<Structs::LabelStruct::Type, chip::DeviceLayer::kMaxUserLabelListLength> labels;
+    for (size_t i = 0; i < labels.size(); i++)
+    {
+        labels[i].label = "label"_span;
+        labels[i].value = "value"_span;
+    }
+    ASSERT_EQ(tester.WriteAttribute(LabelList::Id, DataModel::List(labels.data(), labels.size())), CHIP_NO_ERROR);
+}

src/app/clusters/user-label-server/user-label-cluster.cpp

@@ -68,11 +68,8 @@ CHIP_ERROR ReadLabelList(EndpointId endpoint, AttributeValueEncoder & encoder)
 /// Matches constraints on a LabelStruct.
 bool IsValidLabelEntry(const Structs::LabelStruct::Type & entry)
 {
-    constexpr size_t kMaxLabelSize = 16;
-    constexpr size_t kMaxValueSize = 16;
-
     // NOTE: spec default for label and value is empty, so empty is accepted here
-    return (entry.label.size() <= kMaxLabelSize) && (entry.value.size() <= kMaxValueSize);
+    return (entry.label.size() <= UserLabelCluster::kMaxLabelSize) && (entry.value.size() <= UserLabelCluster::kMaxValueSize);
 }
 
 CHIP_ERROR WriteLabelList(const ConcreteDataAttributePath & path, AttributeValueDecoder & decoder)

src/app/clusters/user-label-server/user-label-cluster.h

@@ -37,6 +37,10 @@ class UserLabelCluster : public DefaultServerCluster, public chip::FabricTable::
     DataModel::ActionReturnStatus WriteAttribute(const DataModel::WriteAttributeRequest & request,
                                                  AttributeValueDecoder & decoder) override;
     CHIP_ERROR Attributes(const ConcreteClusterPath & path, ReadOnlyBufferBuilder<DataModel::AttributeEntry> & builder) override;
+
+    // Constraints for label entries
+    static constexpr size_t kMaxLabelSize = 16;
+    static constexpr size_t kMaxValueSize = 16;
 };
 
 } // namespace chip::app::Clusters