Skip to content

Commit fcf3bee

Browse files
committed
with_args and wrap_with cannot take a tuple argument anymore
Signed-off-by: Maciej Grela <[email protected]>
1 parent a510d46 commit fcf3bee

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

scripts/tests/chiptest/linux.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ def terminate(self):
200200
self.run(command)
201201

202202
def wrap_in_namespace(self, subproc: SubprocessInfo):
203-
return subproc.wrap_with(("ip", "netns", "exec", "{}-{}".format(subproc.kind, self.index)))
203+
return subproc.wrap_with("ip", "netns", "exec", "{}-{}".format(subproc.kind, self.index))
204204

205205

206206
class LinuxNamespacedExecutor(Executor):

scripts/tests/chiptest/runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ def __init__(self, executor=None, capture_delegate=None):
157157
def RunSubprocess(self, subproc: SubprocessInfo, name: str, wait=True, dependencies=[], timeout_seconds: typing.Optional[int] = None, stdin=None):
158158
if sys.platform == 'darwin':
159159
# Try harder to avoid any stdout buffering in our tests
160-
subproc = subproc.wrap_with(('stdbuf', '-o0', '-i0'))
160+
subproc = subproc.wrap_with('stdbuf', '-o0', '-i0')
161161

162162
logging.info('RunSubprocess starting application %s' % subproc)
163163
cmd = subproc.to_cmd()

scripts/tests/chiptest/test_definition.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def wait(self, timeout=None):
131131
self.cv_stopped.wait()
132132

133133
def __startServer(self):
134-
subproc = self.subproc.with_args('--interface-id', str(-1))
134+
subproc = self.subproc.with_args('--interface-id', '-1')
135135

136136
if not self.options:
137137
logging.debug('Executing application under test with default args')

scripts/tests/run_test_suite.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ def build_app(arg_value, kind: str, key: str):
353353
energy_management_app = build_app(energy_management_app, 'app', 'chip-energy-management-app')
354354
closure_app = build_app(closure_app, 'app', 'closure-app')
355355
matter_repl_yaml_tester = build_app(matter_repl_yaml_tester, 'tool',
356-
'yamltest_with_matter_repl_tester.py').wrap_with(('python3',))
356+
'yamltest_with_matter_repl_tester.py').wrap_with('python3')
357357

358358
if chip_tool_with_python is None:
359359
if context.obj.runtime == TestRunTime.DARWIN_FRAMEWORK_TOOL_PYTHON:
@@ -362,7 +362,7 @@ def build_app(arg_value, kind: str, key: str):
362362
chip_tool_with_python = build_app(None, 'tool', 'chiptool.py')
363363

364364
if chip_tool_with_python is not None:
365-
chip_tool_with_python = chip_tool_with_python.wrap_with(('python3',))
365+
chip_tool_with_python = chip_tool_with_python.wrap_with('python3')
366366

367367
if ble_wifi and sys.platform != "linux":
368368
raise click.BadOptionUsage("ble-wifi", "Option --ble-wifi is available on Linux platform only")

0 commit comments

Comments
 (0)