[Linux] Fix bootstrap failure after python update #41836
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bootstrap failure on Linux when the system's Python version is newer than what the build environment expects. The fix involves explicitly using a specific version of Python (3.11) from CIPD for Linux, mirroring the existing setup for macOS and Windows. The change in scripts/setup/bootstrap.sh is correct and effectively enforces a consistent Python environment across all platforms, which should resolve the build issue. The implementation is clean and follows the established pattern in the script.
There was a problem hiding this comment.
Pull Request Overview
This PR adds Linux platform support to the Pigweed CIPD JSON generation process by including a platform-specific Python CIPD JSON configuration entry.
Key Changes
- Added Linux platform entry (
-e linux:$_PYTHON_CIPD_JSON) to thegen_pigweed_cipd_json.pyscript invocation in the bootstrap process
2 participants
Summary
The bootstrap script is trying to use Python 3.11 specifically, when your Linux system has been updated to Python 3.13. The error message mentions python3.11-venv but you have python3-venv for Python 3.13 installed.
The issue is on line 153-154 of bootstrap.sh. It's hardcoding python311.json for Darwin and Windows, but NOT for Linux. The script assumes Linux will use the system Python, which now is Python 3.13, but the Pigweed setup is trying to create a venv with Python 3.11 specific packages.
This PR use Python from CIPD for Linux, just like it does for Darwin and Windows. This will ensure that Python 3.11 is downloaded and used consistently across all platforms, avoiding conflicts with your system's Python 3.13.
Re-run the bootstrap script:
This should now download Python 3.11 from CIPD for Linux and create the virtual environment successfully, avoiding the conflict with your system's Python 3.13.
The change I made adds -e linux:$_PYTHON_CIPD_JSON to the gen_pigweed_cipd_json.py command, which tells it to include the Python 3.11 CIPD package for Linux as well.
Related issues
N/A
Testing
rm -rf .environment
Re-run the bootstrap script:
source scripts/bootstrap.sh --platform linux
Readability checklist