Getting an uncaught error when calling getIntegerFromAttribute with null values. (#1304)

brdandu · web-flow · commit 3fd3d638d070 · 2024-04-11T14:59:48.000-04:00
diff --git a/src-electron/validation/validation.js b/src-electron/validation/validation.js
@@ -239,8 +239,12 @@ function isBigInteger(bits) {
 
 async function getBoundsInteger(attribute, typeSize, isSigned) {
   return {
-    min: await getIntegerFromAttribute(attribute.min, typeSize, isSigned),
-    max: await getIntegerFromAttribute(attribute.max, typeSize, isSigned),
+    min: attribute.min
+      ? await getIntegerFromAttribute(attribute.min, typeSize, isSigned)
+      : null,
+    max: attribute.max
+      ? await getIntegerFromAttribute(attribute.max, typeSize, isSigned)
+      : null,
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -239,8 +239,12 @@ function isBigInteger(bits) {`
`239`	`239`
`240`	`240`	`async function getBoundsInteger(attribute, typeSize, isSigned) {`
`241`	`241`	`return {`
`242`		`- min: await getIntegerFromAttribute(attribute.min, typeSize, isSigned),`
`243`		`- max: await getIntegerFromAttribute(attribute.max, typeSize, isSigned),`
	`242`	`+ min: attribute.min`
	`243`	`+ ? await getIntegerFromAttribute(attribute.min, typeSize, isSigned)`
	`244`	`+ : null,`
	`245`	`+ max: attribute.max`
	`246`	`+ ? await getIntegerFromAttribute(attribute.max, typeSize, isSigned)`
	`247`	`+ : null,`
`244`	`248`	`}`
`245`	`249`	`}`
`246`	`250`