Fix download-artifact script - use github token for all Github API calls (#1647)

- package download-artifact using node 16 (better performance)
- add brief comments to download-artifact.ts to satisy linting rules

Author: dhchandw

.gitignore

@@ -11,8 +11,8 @@ docs/zap-schema.dot
 .quasar
 /dist
 
-#We don't save the coverage within 
-#this repo. 
+#We don't save the coverage within
+#this repo.
 test/jest/coverage
 test/jest/__tests__/data/zap.sqlite
 test/.zap
@@ -86,6 +86,9 @@ reports
 # clinic.js performance profiling data
 .clinic
 
+# Compiled JavaScript output from TypeScript source
+src-script/download-artifact.js
+
 # Downloaded artifacts from Nexus / Github / etc via download-artifact script
 artifacts
 **/zap-*.zip

package.json

@@ -20,7 +20,7 @@
   "bin": "dist/src-electron/main-process/main.js",
   "scripts": {
     "download-artifact": "npx ts-node src-script/download-artifact.ts",
-    "pkg:download-artifact": "npx pkg src-script/download-artifact.js  -t node18-linux-x64,node18-linux-arm64,node18-macos-x64,node18-win-x64 --output dist/download-artifact --compress GZip",
+    "pkg:download-artifact": "npx pkg src-script/download-artifact.js  -t node16-linux-x64,node16-linux-arm64,node16-macos-x64,node16-win-x64 --output dist/download-artifact --compress GZip",
     "compile:download-artifact": "tsc src-script/download-artifact.ts --esModuleInterop",
     "test:download-artifact": "npx jest --collectCoverage=false ./test/download-artifact.test.js --testPathIgnorePatterns=[]",
     "lic": "node src-script/license-check.js --production",