diff --git a/CHANGES b/CHANGES index df9d105b96..26308e379f 100644 --- a/CHANGES +++ b/CHANGES @@ -15,6 +15,11 @@ Platform 3.27 package private configuration attributes. The configuration classes and their configuration getters and setters must be made public. +* Sample and skeleton servers + + We removed discovery and switched from reporting-client to reporting-prometheus + in both the sample and skeleton servers. + * Library Upgrades - ByteBuddy to 1.15.11 (was 1.12.9) diff --git a/jmx/pom.xml b/jmx/pom.xml index ad6d5c3957..c4ae717822 100644 --- a/jmx/pom.xml +++ b/jmx/pom.xml @@ -24,7 +24,7 @@ com.proofpoint.platform - discovery + node diff --git a/sample-server/etc/config.properties b/sample-server/etc/config.properties index 1dc07bfa09..af2777b893 100644 --- a/sample-server/etc/config.properties +++ b/sample-server/etc/config.properties @@ -1,3 +1 @@ node.environment=test -testing.discovery.static=true -service-balancer.reporting.uri=https://pulse-int-ingest.lab.ppops.net diff --git a/sample-server/pom.xml b/sample-server/pom.xml index 2745223442..e8dc610433 100644 --- a/sample-server/pom.xml +++ b/sample-server/pom.xml @@ -79,11 +79,6 @@ bootstrap - - com.proofpoint.platform - discovery - - com.proofpoint.platform log @@ -116,7 +111,7 @@ com.proofpoint.platform - reporting-client + reporting-prometheus diff --git a/sample-server/src/main/java/com/proofpoint/platform/sample/Main.java b/sample-server/src/main/java/com/proofpoint/platform/sample/Main.java index 4bc84fb050..c5d86647c9 100644 --- a/sample-server/src/main/java/com/proofpoint/platform/sample/Main.java +++ b/sample-server/src/main/java/com/proofpoint/platform/sample/Main.java @@ -17,8 +17,6 @@ import com.google.inject.Injector; import com.proofpoint.audit.AuditLogModule; -import com.proofpoint.discovery.client.DiscoveryModule; -import com.proofpoint.discovery.client.announce.Announcer; import com.proofpoint.http.server.HttpServerModule; import com.proofpoint.jaxrs.JaxrsModule; import com.proofpoint.jmx.JmxHttpModule; @@ -27,8 +25,8 @@ import com.proofpoint.log.LogJmxModule; import com.proofpoint.log.Logger; import com.proofpoint.node.NodeModule; -import com.proofpoint.reporting.ReportingClientModule; import com.proofpoint.reporting.ReportingModule; +import com.proofpoint.reporting.ReportingPrometheusModule; import org.weakref.jmx.guice.MBeanModule; import static com.proofpoint.bootstrap.Bootstrap.bootstrapApplication; @@ -47,7 +45,6 @@ public static void main(String[] args) Injector injector = bootstrapApplication("sample-server") .withModules( new NodeModule(), - new DiscoveryModule(), new HttpServerModule(), new JsonModule(), new JaxrsModule(), @@ -57,12 +54,10 @@ public static void main(String[] args) new LogJmxModule(), new AuditLogModule(), new ReportingModule(), - new ReportingClientModule(), + new ReportingPrometheusModule(), new MainModule() ) .initialize(); - - injector.getInstance(Announcer.class).start(); } catch (Throwable e) { log.error(e); diff --git a/sample-server/src/main/java/com/proofpoint/platform/sample/MainModule.java b/sample-server/src/main/java/com/proofpoint/platform/sample/MainModule.java index 26584097bd..e5afbe70dc 100644 --- a/sample-server/src/main/java/com/proofpoint/platform/sample/MainModule.java +++ b/sample-server/src/main/java/com/proofpoint/platform/sample/MainModule.java @@ -22,7 +22,6 @@ import com.google.inject.Scopes; import static com.proofpoint.configuration.ConfigBinder.bindConfig; -import static com.proofpoint.discovery.client.DiscoveryBinder.discoveryBinder; import static com.proofpoint.jaxrs.JaxrsBinder.jaxrsBinder; import static com.proofpoint.reporting.HealthBinder.healthBinder; import static com.proofpoint.reporting.ReportBinder.reportBinder; @@ -43,8 +42,6 @@ public void configure(Binder binder) jaxrsBinder(binder).bind(PersonResource.class).withApplicationPrefix(); bindConfig(binder).bind(StoreConfig.class); - - discoveryBinder(binder).bindHttpAnnouncement("person"); } @Provides diff --git a/skeleton-server/etc/config.properties b/skeleton-server/etc/config.properties index 4e87184ce0..f46d4a2dff 100644 --- a/skeleton-server/etc/config.properties +++ b/skeleton-server/etc/config.properties @@ -1,5 +1,3 @@ node.environment=test -testing.discovery.static=true -service-balancer.reporting.uri=https://pulse-int-ingest.lab.ppops.net http-server.http.enabled=true http-server.https.enabled=false diff --git a/skeleton-server/pom.xml b/skeleton-server/pom.xml index d525bab9e7..c0cc6b2d5c 100644 --- a/skeleton-server/pom.xml +++ b/skeleton-server/pom.xml @@ -49,11 +49,6 @@ bootstrap - - com.proofpoint.platform - discovery - - com.proofpoint.platform log @@ -86,7 +81,7 @@ com.proofpoint.platform - reporting-client + reporting-prometheus diff --git a/skeleton-server/src/main/java/com/proofpoint/platform/skeleton/Main.java b/skeleton-server/src/main/java/com/proofpoint/platform/skeleton/Main.java index 3f293ee3db..5c9a6af243 100644 --- a/skeleton-server/src/main/java/com/proofpoint/platform/skeleton/Main.java +++ b/skeleton-server/src/main/java/com/proofpoint/platform/skeleton/Main.java @@ -18,7 +18,6 @@ import com.google.common.collect.ImmutableMap; import com.google.inject.Injector; import com.proofpoint.audit.AuditLogModule; -import com.proofpoint.discovery.client.DiscoveryModule; import com.proofpoint.discovery.client.announce.Announcer; import com.proofpoint.http.server.HttpServerModule; import com.proofpoint.jaxrs.JaxrsModule; @@ -28,8 +27,8 @@ import com.proofpoint.log.LogJmxModule; import com.proofpoint.log.Logger; import com.proofpoint.node.NodeModule; -import com.proofpoint.reporting.ReportingClientModule; import com.proofpoint.reporting.ReportingModule; +import com.proofpoint.reporting.ReportingPrometheusModule; import org.weakref.jmx.guice.MBeanModule; import static com.proofpoint.bootstrap.Bootstrap.bootstrapApplication; @@ -48,7 +47,6 @@ public static void main(String[] args) Injector injector = bootstrapApplication("skeleton") .withModules( new NodeModule(), - new DiscoveryModule(), new HttpServerModule(), new JsonModule(), new JaxrsModule(), @@ -58,7 +56,7 @@ public static void main(String[] args) new LogJmxModule(), new AuditLogModule(), new ReportingModule(), - new ReportingClientModule(), + new ReportingPrometheusModule(), new MainModule() ) .withApplicationDefaults(ImmutableMap.builder() diff --git a/skeleton-server/src/main/java/com/proofpoint/platform/skeleton/MainModule.java b/skeleton-server/src/main/java/com/proofpoint/platform/skeleton/MainModule.java index ffb168f1fa..21ff78904f 100644 --- a/skeleton-server/src/main/java/com/proofpoint/platform/skeleton/MainModule.java +++ b/skeleton-server/src/main/java/com/proofpoint/platform/skeleton/MainModule.java @@ -18,8 +18,6 @@ import com.google.inject.Binder; import com.google.inject.Module; -import static com.proofpoint.discovery.client.DiscoveryBinder.discoveryBinder; - public class MainModule implements Module { @@ -28,7 +26,5 @@ public void configure(Binder binder) { binder.requireExplicitBindings(); binder.disableCircularProxies(); - - discoveryBinder(binder).bindHttpAnnouncement("skeleton"); } }