Treat assert() as failing

[orklah]

vimeo/psalm#6989 reported a case where psalm is failing due to an assert() in php-parser but psalm.dev continues the analysis. I think psalm.dev should behave as if we were in dev environment because this is usually the way Psalm runs

[weirdan]

Controlled by these settings:
https://www.php.net/manual/en/ini.core.php#ini.zend.assertions
https://www.php.net/manual/en/info.configuration.php#ini.assert.exception

[orklah]

Do you think we'll be allowed to change those directly from code or should we ask Matt to change this in the host panel?

[orklah]

Doc says

If a process is started in production mode, zend.assertions cannot be changed at runtime, since the code for assertions was not generated.

So, php.ini change is mandatory

[orklah]

@muglug could you take a look at this when you have time? It would be great to have psalm.dev behaving correctly when failing an assertion

[weirdan]

I think this is fixed now. @muglug can you confirm you enabled assertions on https://psalm.dev?