OSP: wrong documentation for allowed environment name characters (maybe?)

[bastelfreak]

Describe the Bug

From https://www.puppet.com/docs/puppet/7/environments_creating#env_structure

Note: Environment names can contain lowercase letters, numbers, and underscores. They must match the following regular expression rule: \A[a-z0-9_]+\Z. If you are using Puppet 5, remove the environment_data_provider setting.

I can deploy environments with r10k that contain lowercase and uppercase letters. I also didn't notice any issues while doing a quick test. Also r10k didn't correct my environment FOO to foo. Are uppercase letters supported and just the docs aren't up2date?

Expected Behavior

Support lower- and uppercase letters in environment names.

Steps to Reproduce

• deploy an environment named FOO
• run puppet agent -t --environment FOO

Environment

• Puppet 8.6.0
• Ubuntu 20.04

Additional Context

There is also https://www.puppet.com/docs/puppet/7/lang_reserved.html#environment-names

[github-actions]

Migrated issue to PUPDOC-5661

[joshcooper]

@bastelfreak The behavior may depend on whether your filesystem is case-insensitive, but case-preserving as is the default on macOS

[bastelfreak]

Does that mean that Puppet/puppetserver itself don't have those restrictions, only maybe the used filesystem?

I also did some testing with PE 2021 and PE 2023 and code-manager and classifier seem to work totally fine with uppercase letters.

[bastelfreak]

Hey,
I need to validate branch names for a larger PE installation. Is there any chance someone can take a look soonish?

[bastelfreak]

Hello, could someone please take a look here?