Skip to content

Reduce required inputs for ModelChain.run_model_from_effective_irradiance #1411

Open
@cwhanse

Description

@cwhanse

ModelChain.run_model_from_effective_irradiance requires that the ModelChain instance has attributes which the method doesn't use, e.g., ModelChain.aoi_model. It would be nice if the method runs without requiring these attributes.

"It's a small inelegance that specifying aoi_model is necessary for a ModelChain that only uses run_model_from_effective_irradiance. I don't see a way around it, so I don't think there's anything to be done in this PR, just thinking out loud about the ModelChain design."

Originally posted by @kanderso-nrel in #1394 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions