Do not reuse temporary file in server.script()

link2xt · Fizzadar · commit b59da0352303 · 2022-12-31T09:11:17.000Z
Even if `src` is the same, other parameters
such as `_su_user` may be different. In this
case pyinfra unconditionally tries to run `chmod +x`
on the file and fails, because the file is
already uploaded as a different user.
diff --git a/pyinfra/operations/server.py b/pyinfra/operations/server.py
@@ -172,7 +172,7 @@ def script(src):
         )
     """
 
-    temp_file = state.get_temp_filename(src)
+    temp_file = state.get_temp_filename()
     yield from files.put(src, temp_file)
 
     yield chmod(temp_file, "+x")

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ def script(src):`
`172`	`172`	`)`
`173`	`173`	`"""`
`174`	`174`
`175`		`- temp_file = state.get_temp_filename(src)`
	`175`	`+ temp_file = state.get_temp_filename()`
`176`	`176`	`yield from files.put(src, temp_file)`
`177`	`177`
`178`	`178`	`yield chmod(temp_file, "+x")`