: actor: port receiver monitoring is made non-optional #578
+112
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary: Rollback Plan: Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
ccf6e47 to
f837492
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary: Pull Request resolved: pytorch-labs#578 Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
f837492 to
b2f6675
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary: Pull Request resolved: pytorch-labs#578 Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
b2f6675 to
1fa2092
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
1fa2092 to
c929fd8
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary: Pull Request resolved: pytorch-labs#578 Differential Revision: D78528860
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
c929fd8 to
cf9083f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
cf9083f to
98f7c5b
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
98f7c5b to
ca4e12c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary: Pull Request resolved: pytorch-labs#578 this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python. the essential change is that: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> "PortTuple[R]": monitor = ( None if self._actor_mesh._actor_mesh is None else self._actor_mesh._actor_mesh.monitor() ) return PortTuple.create(self._mailbox, monitor, once) ``` becomes: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> PortTuple[R]: p, r = PortTuple.create(self._mailbox, once) return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver))) ``` `_supervise(...)` dispatches to new Rust helpers: ```python mesh.supervise_port(...) and mesh.supervise_once_port(...) ``` which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`. most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired. this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust. Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
ca4e12c to
487d23d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary: Pull Request resolved: pytorch-labs#578 this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python. the essential change is that: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> "PortTuple[R]": monitor = ( None if self._actor_mesh._actor_mesh is None else self._actor_mesh._actor_mesh.monitor() ) return PortTuple.create(self._mailbox, monitor, once) ``` becomes: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> PortTuple[R]: p, r = PortTuple.create(self._mailbox, once) return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver))) ``` `_supervise(...)` dispatches to new Rust helpers: ```python mesh.supervise_port(...) and mesh.supervise_once_port(...) ``` which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`. most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired. this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust. Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
487d23d to
b6f2363
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
- the creation and wiring of the monitor stream is now fully in rust.
- the responsibility of wrapping receivers with supervision is now fully in rust.
- python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
b6f2363 to
db42224
Compare
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
c9d2505 to
cd54193
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
- the creation and wiring of the monitor stream is now fully in rust.
- the responsibility of wrapping receivers with supervision is now fully in rust.
- python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
2 times, most recently
from
3a93f96 to
3fd2829
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
- the creation and wiring of the monitor stream is now fully in rust.
- the responsibility of wrapping receivers with supervision is now fully in rust.
- python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
3fd2829 to
774ab14
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
- the creation and wiring of the monitor stream is now fully in rust.
- the responsibility of wrapping receivers with supervision is now fully in rust.
- python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary: Pull Request resolved: pytorch-labs#578 this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python. the essential change is that: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> "PortTuple[R]": monitor = ( None if self._actor_mesh._actor_mesh is None else self._actor_mesh._actor_mesh.monitor() ) return PortTuple.create(self._mailbox, monitor, once) ``` becomes: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> PortTuple[R]: p, r = PortTuple.create(self._mailbox, once) return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver))) ``` `_supervise(...)` dispatches to new Rust helpers: ```python mesh.supervise_port(...) and mesh.supervise_once_port(...) ``` which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`. most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired. - the creation and wiring of the monitor stream is now fully in rust. - the responsibility of wrapping receivers with supervision is now fully in rust. - python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust. Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
774ab14 to
cba1703
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary: Pull Request resolved: pytorch-labs#578 this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python. the essential change is that: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> "PortTuple[R]": monitor = ( None if self._actor_mesh._actor_mesh is None else self._actor_mesh._actor_mesh.monitor() ) return PortTuple.create(self._mailbox, monitor, once) ``` becomes: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> PortTuple[R]: p, r = PortTuple.create(self._mailbox, once) return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver))) ``` `_supervise(...)` dispatches to new Rust helpers: ```python mesh.supervise_port(...) and mesh.supervise_once_port(...) ``` which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`. most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired. - the creation and wiring of the monitor stream is now fully in rust. - the responsibility of wrapping receivers with supervision is now fully in rust. - python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust. Differential Revision: D78528860
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
force-pushed
the
export-D78528860
branch
2 times, most recently
from
de8a1b3 to
d1e3a5c
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
- the creation and wiring of the monitor stream is now fully in rust.
- the responsibility of wrapping receivers with supervision is now fully in rust.
- python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 19, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
- the creation and wiring of the monitor stream is now fully in rust.
- the responsibility of wrapping receivers with supervision is now fully in rust.
- python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
d1e3a5c to
5eb8ac4
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 19, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
- the creation and wiring of the monitor stream is now fully in rust.
- the responsibility of wrapping receivers with supervision is now fully in rust.
- python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
2 times, most recently
from
278f95f to
3e97aaa
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 19, 2025
Summary:
this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python.
the essential change is that:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> "PortTuple[R]":
monitor = (
None
if self._actor_mesh._actor_mesh is None
else self._actor_mesh._actor_mesh.monitor()
)
return PortTuple.create(self._mailbox, monitor, once)
```
becomes:
```
class ActorEndpoint(...):
def _port(self, once: bool = False) -> PortTuple[R]:
p, r = PortTuple.create(self._mailbox, once)
return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver)))
```
`_supervise(...)` dispatches to new Rust helpers:
```python
mesh.supervise_port(...) and mesh.supervise_once_port(...)
```
which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`.
most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired.
- the creation and wiring of the monitor stream is now fully in rust.
- the responsibility of wrapping receivers with supervision is now fully in rust.
- python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded
this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust.
Differential Revision: D78528860
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 19, 2025
Summary: Pull Request resolved: pytorch-labs#578 this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python. the essential change is that: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> "PortTuple[R]": monitor = ( None if self._actor_mesh._actor_mesh is None else self._actor_mesh._actor_mesh.monitor() ) return PortTuple.create(self._mailbox, monitor, once) ``` becomes: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> PortTuple[R]: p, r = PortTuple.create(self._mailbox, once) return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver))) ``` `_supervise(...)` dispatches to new Rust helpers: ```python mesh.supervise_port(...) and mesh.supervise_once_port(...) ``` which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`. most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired. - the creation and wiring of the monitor stream is now fully in rust. - the responsibility of wrapping receivers with supervision is now fully in rust. - python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust. Differential Revision: D78528860
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
3e97aaa to
693ad30
Compare
Summary: Pull Request resolved: pytorch-labs#578 this diff moves supervision logic from python into rust, aligning with the goal of eliminating complex supervision wiring in python. the essential change is that: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> "PortTuple[R]": monitor = ( None if self._actor_mesh._actor_mesh is None else self._actor_mesh._actor_mesh.monitor() ) return PortTuple.create(self._mailbox, monitor, once) ``` becomes: ``` class ActorEndpoint(...): def _port(self, once: bool = False) -> PortTuple[R]: p, r = PortTuple.create(self._mailbox, once) return PortTuple(p, PortReceiver(self._mailbox, self._supervise(r._receiver))) ``` `_supervise(...)` dispatches to new Rust helpers: ```python mesh.supervise_port(...) and mesh.supervise_once_port(...) ``` which wrap the receivers with supervision logic (including selection between message arrival and supervision events), completely eliminating the need for python-side constructs like `ActorMeshMonitor`. most of the python complexity introduced in D77434080 is removed. the only meaningful addition is `_supervise(...)`, a small overrideable hook that defaults to a no-op and cleanly delegates to rust when supervision is desired. - the creation and wiring of the monitor stream is now fully in rust. - the responsibility of wrapping receivers with supervision is now fully in rust. - python no longer constructs or passes supervision monitors; rust now owns the full wiring, and python receives already-wrapped receivers with supervision behavior embedded this is a strict improvement: lower complexity, cleaner override points and supervision is entirely managed in rust. Differential Revision: D78528860
|
This pull request was exported from Phabricator. Differential Revision: D78528860 |
shayne-fletcher
force-pushed
the
export-D78528860
branch
from
693ad30 to
cf7434a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D78528860