-
Notifications
You must be signed in to change notification settings - Fork 86
Open
Labels
Description
I noticed for many of my PRs after running ./format.sh
, it still does not pass the checks in ./check.sh
. This causes the PR to fail in the lint check in CI. The reason is because ./format.sh
does not satisfy all the requirements in ./check.sh
, check.sh is using ufmt and format is using some packages like autoflake or isort that do not work completely:
Lines 40 to 52 in f2e605d
# TODO: enable autoflake and isort. | |
# these are not currently enabeled because the existing | |
# import structure has magic side-effects that need to | |
# be cleaned up so that isort and autoflake don't break them. | |
# | autoflake \ | |
# --stdin-display-name "$TARGET" \ | |
# --remove-all-unused-imports \ | |
# - \ | |
# | isort \ | |
# --filename "$TARGET" \ | |
# - \ | |
I wonder if we can just turn to an all in one solution like ruff (https://github.com/astral-sh/ruff) to act as both our linter, formatter, and checker.