From 14c144b727bbb52d9ad93cb107fd370c8b977510 Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Thu, 2 Oct 2025 10:40:04 -0700 Subject: [PATCH 01/10] add config --- .../v3/components/benchmarkList/BenchmarkCategoryCard.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx index 8746dcc6c7..b62ccf2b0d 100644 --- a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx +++ b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx @@ -15,6 +15,7 @@ import { Typography, } from "@mui/material"; import { Box } from "@mui/system"; +import { wrap } from "module"; import Link from "next/link"; import ReactMarkdown from "react-markdown"; From 6a3b85e258d9e18717ca96eacd19319572c84598 Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Mon, 6 Oct 2025 08:51:08 -0700 Subject: [PATCH 02/10] add config --- .../components/benchmark/v3/configs/teams/compilers/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/torchci/components/benchmark/v3/configs/teams/compilers/config.ts b/torchci/components/benchmark/v3/configs/teams/compilers/config.ts index 705d1c4bc1..56ea68571f 100644 --- a/torchci/components/benchmark/v3/configs/teams/compilers/config.ts +++ b/torchci/components/benchmark/v3/configs/teams/compilers/config.ts @@ -38,7 +38,7 @@ const COMPILATION_LATENCY_COMPARISON_POLICY: BenchmarkComparisonPolicyConfig = { target: "compilation_latency", type: "ratio", ratioPolicy: { - badRatio: 1.1, + badRatio: 1.05, goodRatio: 0.9, direction: "down", }, From e62f208a2a2927af2f7ca8811c45bdccd516d5c2 Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Wed, 8 Oct 2025 11:41:20 -0700 Subject: [PATCH 03/10] add config --- .../components/benchmark/v3/configs/teams/compilers/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/torchci/components/benchmark/v3/configs/teams/compilers/config.ts b/torchci/components/benchmark/v3/configs/teams/compilers/config.ts index 56ea68571f..9d52f88334 100644 --- a/torchci/components/benchmark/v3/configs/teams/compilers/config.ts +++ b/torchci/components/benchmark/v3/configs/teams/compilers/config.ts @@ -155,7 +155,7 @@ export const CompilerPrecomputeBenchmarkUIConfig: BenchmarkUIConfig = { }, query_params: { type: "converter", - id: "compilerDataRenderConverter", + id: "compilerQueryParameterConverter", }, }, dataRender: { From 178ebe0169974f698efc35d2873d2d9b2388cc25 Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Wed, 8 Oct 2025 11:45:19 -0700 Subject: [PATCH 04/10] add config --- .../v3/components/benchmarkList/BenchmarkCategoryCard.tsx | 1 - .../components/benchmark/v3/configs/teams/compilers/config.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx index b62ccf2b0d..8746dcc6c7 100644 --- a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx +++ b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx @@ -15,7 +15,6 @@ import { Typography, } from "@mui/material"; import { Box } from "@mui/system"; -import { wrap } from "module"; import Link from "next/link"; import ReactMarkdown from "react-markdown"; diff --git a/torchci/components/benchmark/v3/configs/teams/compilers/config.ts b/torchci/components/benchmark/v3/configs/teams/compilers/config.ts index 9d52f88334..e3f7beaa14 100644 --- a/torchci/components/benchmark/v3/configs/teams/compilers/config.ts +++ b/torchci/components/benchmark/v3/configs/teams/compilers/config.ts @@ -38,7 +38,7 @@ const COMPILATION_LATENCY_COMPARISON_POLICY: BenchmarkComparisonPolicyConfig = { target: "compilation_latency", type: "ratio", ratioPolicy: { - badRatio: 1.05, + badRatio: 1.1, goodRatio: 0.9, direction: "down", }, From 5f6185444e45dcb9d587e0ab24a2e68ef4be0581 Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Wed, 8 Oct 2025 12:00:21 -0700 Subject: [PATCH 05/10] add config --- .../v3/components/common/SelectionDialog.tsx | 2 +- .../components/benchmark/v3/configs/configBook.tsx | 5 ++++- .../configComponentRegistration.tsx} | 11 ++--------- .../v3/configs/utils/dataBindingRegistration.tsx | 5 ++++- 4 files changed, 11 insertions(+), 12 deletions(-) rename torchci/components/benchmark/v3/configs/{configRegistration.tsx => utils/configComponentRegistration.tsx} (50%) diff --git a/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx b/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx index ec440aff59..68626cd7c4 100644 --- a/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx +++ b/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx @@ -7,8 +7,8 @@ import { } from "@mui/material"; import { Typography } from "@mui/material"; -import { resolveComponent } from "../../configs/configRegistration"; import { RawTimeSeriesPoint } from "../dataRender/components/benchmarkTimeSeries/helper"; +import { resolveComponent } from "../../configs/utils/configComponentRegistration"; export interface TimeSeriesChartDialogContentProps { left: RawTimeSeriesPoint | null; diff --git a/torchci/components/benchmark/v3/configs/configBook.tsx b/torchci/components/benchmark/v3/configs/configBook.tsx index f13e40138c..e898b7f9ec 100644 --- a/torchci/components/benchmark/v3/configs/configBook.tsx +++ b/torchci/components/benchmark/v3/configs/configBook.tsx @@ -1,9 +1,12 @@ import { DefaultFanoutRenderContent } from "../components/dataRender/fanout/defaultFanoutRenderContent"; -import { NotFoundComponent, resolveComponent } from "./configRegistration"; import { CompilerPrecomputeBenchmarkUIConfig, COMPILTER_PRECOMPUTE_BENCHMARK_ID, } from "./teams/compilers/config"; +import { + NotFoundComponent, + resolveComponent, +} from "./utils/configComponentRegistration"; import { DataBinding, DataBindingConfig, diff --git a/torchci/components/benchmark/v3/configs/configRegistration.tsx b/torchci/components/benchmark/v3/configs/utils/configComponentRegistration.tsx similarity index 50% rename from torchci/components/benchmark/v3/configs/configRegistration.tsx rename to torchci/components/benchmark/v3/configs/utils/configComponentRegistration.tsx index fbd177733d..f1d23bff1c 100644 --- a/torchci/components/benchmark/v3/configs/configRegistration.tsx +++ b/torchci/components/benchmark/v3/configs/utils/configComponentRegistration.tsx @@ -1,19 +1,12 @@ import React from "react"; -import { CompilerPrecomputeConfirmDialogContent } from "./teams/compilers/CompilerPrecomputeConfirmDialogContent"; -import { CompilerSearchBarDropdowns } from "./teams/compilers/CompilerSearchBarDropdowns"; -import { compilerQueryParameterConverter } from "./teams/compilers/config"; -import { QueryParameterConverter } from "./utils/dataBindingRegistration"; +import { CompilerPrecomputeConfirmDialogContent } from "../teams/compilers/CompilerPrecomputeConfirmDialogContent"; +import { CompilerSearchBarDropdowns } from "../teams/compilers/CompilerSearchBarDropdowns"; export const COMPONENT_REGISTRY: Record> = { CompilerSearchBarDropdowns, CompilerPrecomputeConfirmDialogContent, }; -// register converters for data params, this is -export const CONVERTER_REGISTRY: Record = { - compilerQueryParameterConverter, -}; - export function resolveComponent( name: string | undefined | null ): React.ComponentType | undefined { diff --git a/torchci/components/benchmark/v3/configs/utils/dataBindingRegistration.tsx b/torchci/components/benchmark/v3/configs/utils/dataBindingRegistration.tsx index 10dad3fa17..434bb7aa3a 100644 --- a/torchci/components/benchmark/v3/configs/utils/dataBindingRegistration.tsx +++ b/torchci/components/benchmark/v3/configs/utils/dataBindingRegistration.tsx @@ -1,8 +1,11 @@ import dayjs, { Dayjs } from "dayjs"; import { TimeRange } from "lib/benchmark/store/benchmark_regression_store"; import DefaultMetricsDropdowns from "../../components/benchmarkSideBar/components/DefaultSideBarMetricsDropdowns"; -import { NotFoundComponent, resolveComponent } from "../configRegistration"; import { compilerQueryParameterConverter } from "../teams/compilers/config"; +import { + NotFoundComponent, + resolveComponent, +} from "./configComponentRegistration"; export type DataBindingConfig = { initial: BenchmarkUiParameters; From 75cdb2086cb2a7ac158f78c58da80e1de2167497 Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Wed, 8 Oct 2025 12:04:16 -0700 Subject: [PATCH 06/10] add config --- .../benchmark/v3/components/common/SelectionDialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx b/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx index 68626cd7c4..4a9d4c2bf3 100644 --- a/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx +++ b/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx @@ -7,8 +7,8 @@ import { } from "@mui/material"; import { Typography } from "@mui/material"; -import { RawTimeSeriesPoint } from "../dataRender/components/benchmarkTimeSeries/helper"; import { resolveComponent } from "../../configs/utils/configComponentRegistration"; +import { RawTimeSeriesPoint } from "../dataRender/components/benchmarkTimeSeries/helper"; export interface TimeSeriesChartDialogContentProps { left: RawTimeSeriesPoint | null; From 312883d8e377a5898f581581019faae89c1b9a75 Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Thu, 2 Oct 2025 10:40:04 -0700 Subject: [PATCH 07/10] add config --- .../v3/components/benchmarkList/BenchmarkCategoryCard.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx index 85c6e7b032..78f233f9fc 100644 --- a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx +++ b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx @@ -15,6 +15,7 @@ import { Typography, } from "@mui/material"; import { Box } from "@mui/system"; +import { wrap } from "module"; import Link from "next/link"; import ReactMarkdown from "react-markdown"; From c19d3884f8fe6217106702d9f93d66429a6c7b2d Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Wed, 8 Oct 2025 19:30:21 -0700 Subject: [PATCH 08/10] add config --- .../v3/components/benchmarkList/BenchmarkCategoryCard.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx index 78f233f9fc..85c6e7b032 100644 --- a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx +++ b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx @@ -15,7 +15,6 @@ import { Typography, } from "@mui/material"; import { Box } from "@mui/system"; -import { wrap } from "module"; import Link from "next/link"; import ReactMarkdown from "react-markdown"; From c5b7838c92582c83f2b401619cc95d147730f49b Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Thu, 2 Oct 2025 10:40:04 -0700 Subject: [PATCH 09/10] add config --- .../v3/components/benchmarkList/BenchmarkCategoryCard.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx index 85c6e7b032..78f233f9fc 100644 --- a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx +++ b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx @@ -15,6 +15,7 @@ import { Typography, } from "@mui/material"; import { Box } from "@mui/system"; +import { wrap } from "module"; import Link from "next/link"; import ReactMarkdown from "react-markdown"; From 513cf227404401cdd304ca6d22349b02a1d9b70e Mon Sep 17 00:00:00 2001 From: Yang Wang Date: Wed, 8 Oct 2025 19:34:19 -0700 Subject: [PATCH 10/10] add config --- .../v3/components/benchmarkList/BenchmarkCategoryCard.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx index 78f233f9fc..85c6e7b032 100644 --- a/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx +++ b/torchci/components/benchmark/v3/components/benchmarkList/BenchmarkCategoryCard.tsx @@ -15,7 +15,6 @@ import { Typography, } from "@mui/material"; import { Box } from "@mui/system"; -import { wrap } from "module"; import Link from "next/link"; import ReactMarkdown from "react-markdown";