update many rs operations to fix memory leak problem by closing okhttp response in BucketManager.

Author: wubingheng

src/main/java/com/qiniu/storage/BucketManager.java

@@ -11,12 +11,12 @@
 import java.util.Iterator;
 import java.util.Map;
 
-
 /**
  * 主要涉及了空间资源管理及批量操作接口的实现，具体的接口规格可以参考
  * 参考文档：<a href="http://developer.qiniu.com/kodo/api/rs">资源管理</a>
  */
 public final class BucketManager {
+
     /**
      * Auth 对象
      * 该类需要使用QBox鉴权，所以需要指定Auth对象
@@ -27,7 +27,6 @@ public final class BucketManager {
      * Configuration 对象
      * 该类相关的域名配置，解析配置，HTTP请求超时时间设置等
      */
-
     private Configuration configuration;
 
     /**
@@ -53,7 +52,6 @@ public BucketManager(Auth auth, Client client) {
         this.client = client;
     }
 
-
     /**
      * EncodedEntryURI格式，其中 bucket+":"+key 称之为 entry
      *
@@ -83,7 +81,6 @@ public static String encodedEntry(String bucket) {
         return encodedEntry(bucket, null);
     }
 
-
     /**
      * 获取账号下所有空间名称列表
      *
@@ -114,7 +111,6 @@ public void deleteBucket(String bucketname) throws QiniuException {
      * @return 该空间名下的domain
      * @throws QiniuException
      */
-
     public String[] domainList(String bucket) throws QiniuException {
         String url = String.format("%s/v6/domain/list?tbl=%s", configuration.apiHost(), bucket);
         Response r = get(url);
@@ -176,11 +172,15 @@ public FileListing listFiles(String bucket, String prefix, String marker, int li
      * @link http://developer.qiniu.com/kodo/api/stat
      */
     public FileInfo stat(String bucket, String fileKey) throws QiniuException {
-        Response r = rsGet(bucket, String.format("/stat/%s", encodedEntry(bucket, fileKey)));
-        return r.jsonToObject(FileInfo.class);
+        Response res = rsGet(bucket, String.format("/stat/%s", encodedEntry(bucket, fileKey)));
+        if (!res.isOK()) {
+            throw new QiniuException(res);
+        }
+        FileInfo fileInfo = res.jsonToObject(FileInfo.class);
+        res.close();
+        return fileInfo;
     }
 
-
     /**
      * 删除指定空间、文件名的文件
      *
@@ -230,7 +230,6 @@ public Response changeHeaders(String bucket, String key, Map<String, String> hea
         return rsPost(bucket, path, null);
     }
 
-
     /**
      * 修改文件的类型（普通存储或低频存储）
      *
@@ -303,10 +302,13 @@ public Response copy(String fromBucket, String fromFileKey, String toBucket, Str
      */
     public void copy(String fromBucket, String fromFileKey, String toBucket, String toFileKey)
             throws QiniuException {
-        copy(fromBucket, fromFileKey, toBucket, toFileKey, false);
+        Response res = copy(fromBucket, fromFileKey, toBucket, toFileKey, false);
+        if (!res.isOK()) {
+            throw new QiniuException(res);
+        }
+        res.close();
     }
 
-
     /**
      * 移动文件，要求空间在同一账号下
      *
@@ -339,7 +341,6 @@ public Response move(String fromBucket, String fromFileKey, String toBucket, Str
         return move(fromBucket, fromFileKey, toBucket, toFileKey, false);
     }
 
-
     /**
      * 抓取指定地址的文件，以指定名称保存在指定空间
      * 要求指定url可访问，大文件不建议使用此接口抓取。可先下载再上传
@@ -366,8 +367,13 @@ public FetchRet fetch(String url, String bucket, String key) throws QiniuExcepti
         String resource = UrlSafeBase64.encodeToString(url);
         String to = encodedEntry(bucket, key);
         String path = String.format("/fetch/%s/to/%s", resource, to);
-        Response r = ioPost(bucket, path);
-        return r.jsonToObject(FetchRet.class);
+        Response res = ioPost(bucket, path);
+        if (!res.isOK()) {
+            throw new QiniuException(res);
+        }
+        FetchRet fetchRet = res.jsonToObject(FetchRet.class);
+        res.close();
+        return fetchRet;
     }
 
     /**
@@ -381,7 +387,6 @@ public FetchRet fetch(String url, String bucket, String key) throws QiniuExcepti
      * @return Response
      * @throws QiniuException
      */
-
     public Response asynFetch(String url, String bucket, String key) throws QiniuException {
         String requesturl = configuration.apiHost(auth.accessKey, bucket) + "/sisyphus/fetch";
         StringMap stringMap = new StringMap().put("url", url).put("bucket", bucket).putNotNull("key", key);
@@ -446,7 +451,11 @@ public Response checkAsynFetchid(String region, String fetchWorkId) throws Qiniu
     public void prefetch(String bucket, String key) throws QiniuException {
         String resource = encodedEntry(bucket, key);
         String path = String.format("/prefetch/%s", resource);
-        ioPost(bucket, path);
+        Response res = ioPost(bucket, path);
+        if (!res.isOK()) {
+            throw new QiniuException(res);
+        }
+        res.close();
     }
 
     /**
@@ -503,35 +512,36 @@ public Response deleteAfterDays(String bucket, String key, int days) throws Qini
     public void setBucketAcl(String bucket, AclType acl) throws QiniuException {
         String url = String.format("%s/private?bucket=%s&private=%s", configuration.ucHost(), bucket, acl.getType());
         Response res = post(url, null);
-        res.close();
         if (!res.isOK()) {
             throw new QiniuException(res);
         }
+        res.close();
     }
 
     public BucketInfo getBucketInfo(String bucket) throws QiniuException {
         String url = String.format("%s/v2/bucketInfo?bucket=%s", configuration.ucHost(), bucket);
         Response res = post(url, null);
         if (!res.isOK()) {
-            res.close();
             throw new QiniuException(res);
         }
         BucketInfo info = res.jsonToObject(BucketInfo.class);
+        res.close();
         return info;
     }
 
-
     public void setIndexPage(String bucket, IndexPageType type) throws QiniuException {
         String url = String.format("%s/noIndexPage?bucket=%s&noIndexPage=%s",
                 configuration.ucHost(), bucket, type.getType());
         Response res = post(url, null);
+        if (!res.isOK()) {
+            throw new QiniuException(res);
+        }
+        res.close();
     }
 
-
     /*
      * 相关请求的方法列表
      * */
-
     private Response rsPost(String bucket, String path, byte[] body) throws QiniuException {
         check(bucket);
         String url = configuration.rsHost(auth.accessKey, bucket) + path;
@@ -592,7 +602,6 @@ public BatchOperations() {
         /**
          * 添加chgm指令
          */
-
         public BatchOperations addChgmOp(String bucket, String key, String newMimeType) {
             String resource = encodedEntry(bucket, key);
             String encodedMime = UrlSafeBase64.encodeToString(newMimeType);