From d5eff08a61afa17dc4ba558975c2a0fd79a6adc1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Canouil?=
 <8896044+mcanouil@users.noreply.github.com>
Date: Fri, 14 Mar 2025 21:45:09 +0100
Subject: [PATCH 1/3] feat: Add target attribute to links in listing templates
 if provided

---
 .../projects/website/listing/item-default.ejs.md  | 15 +++++++++------
 .../projects/website/listing/item-grid.ejs.md     |  6 +++++-
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/resources/projects/website/listing/item-default.ejs.md b/src/resources/projects/website/listing/item-default.ejs.md
index 91114a7867f..735efe4b1ed 100644
--- a/src/resources/projects/website/listing/item-default.ejs.md
+++ b/src/resources/projects/website/listing/item-default.ejs.md
@@ -32,7 +32,7 @@ return value;
 let value = readField(item, field);
 if (value !== undefined) {
 print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLink(item, field, value)}</div>`);
- }
+}
 }
 %>
 
@@ -41,7 +41,7 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
 <% if (fields.includes('image')) { %>
 
 ```{=html}
-<div class="thumbnail"><a href="<%- item.path %>" class="no-external">
+<div class="thumbnail"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external">
 <% if (item.image) { %>
 <%= listing.utilities.img(itemNumber, item.image, "thumbnail-image", item['image-alt'], item['image-lazy-loading'] ?? listing['image-lazy-loading']) %>
 <% } else { %>
@@ -55,9 +55,10 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
 ::: {.body}
 
 <% if (fields.includes('title')) { %>
-<h3 class="no-anchor listing-title"><a href="<%- item.path %>" class="no-external"><%= item.title %></a></h3>
+
+<h3 class="no-anchor listing-title"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external"><%= item.title %></a></h3>
 <% if (fields.includes('subtitle')) { %>
-<div class="listing-subtitle"><a href="<%- item.path %>" class="no-external"><%= item.subtitle %></a></div>
+<div class="listing-subtitle"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external"><%= item.subtitle %></a></div>
 <% } %>
 <% } %>
 
@@ -76,7 +77,7 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
 <% if (fields.includes('description')) { %>
 
 ```{=html}
-<div class="delink listing-description"><a href="<%- item.path %>" class="no-external">
+<div class="delink listing-description"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external">
 ```
 
 <%= item.description %>
@@ -92,14 +93,16 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
 ::: {.metadata}
 
 ```{=html}
-<a href="<%- item.path %>" class="no-external">
+<a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external">
 ```
 
 <% if (fields.includes('date') && item.date) { %>
+
 <div class="listing-date"><%= item.date %></div>
 <% } %>
 
 <% if (fields.includes('author') && item.author) { %>
+
 <div class="listing-author"><%= item.author %></div>
 <% } %>
 
diff --git a/src/resources/projects/website/listing/item-grid.ejs.md b/src/resources/projects/website/listing/item-grid.ejs.md
index e19307988d9..e14aacd08db 100644
--- a/src/resources/projects/website/listing/item-grid.ejs.md
+++ b/src/resources/projects/website/listing/item-grid.ejs.md
@@ -40,7 +40,7 @@ return !["title", "image", "image-alt", "date", "author", "subtitle", "descripti
 ::: {.g-col-1 <%= listing.utilities.metadataAttrs(item) %> }
 
 ```{=html}
-<a href="<%- item.path %>" class="quarto-grid-link">
+<a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="quarto-grid-link">
 <div class="quarto-grid-item card h-100 <%= `card-${align}` %><%= hideBorders ? ' borderless' : '' %>">
 ```
 
@@ -68,10 +68,12 @@ return !["title", "image", "image-alt", "date", "author", "subtitle", "descripti
 ::: {.card-body .post-contents}
 
 <% if (showField('title')) { %>
+
 <h5 class="no-anchor card-title listing-title"><%= item.title %></h5>
 <% } %>
 
 <% if (showField('subtitle')) { %>
+
 <div class="card-subtitle listing-subtitle"><%= item.subtitle %></div>
 <% } %>
 
@@ -120,10 +122,12 @@ const flexJustify = showField('author') && showField('date') ? "justify" : showF
 ```
 
 <% if (showField('author')) { %>
+
 <div class="listing-author"><%= item.author %></div>
 <% } %>
 
 <% if (showField('date')) { %>
+
 <div class="listing-date"><%= item.date %></div>
 <% } %>
 

From f722a3b5435de3695f63f0ceb7b5378973f9428c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Canouil?=
 <8896044+mcanouil@users.noreply.github.com>
Date: Wed, 2 Apr 2025 23:01:52 +0200
Subject: [PATCH 2/3] chore: Remove extra newline

---
 src/resources/projects/website/listing/item-default.ejs.md | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/resources/projects/website/listing/item-default.ejs.md b/src/resources/projects/website/listing/item-default.ejs.md
index 735efe4b1ed..88549577b72 100644
--- a/src/resources/projects/website/listing/item-default.ejs.md
+++ b/src/resources/projects/website/listing/item-default.ejs.md
@@ -55,7 +55,6 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
 ::: {.body}
 
 <% if (fields.includes('title')) { %>
-
 <h3 class="no-anchor listing-title"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external"><%= item.title %></a></h3>
 <% if (fields.includes('subtitle')) { %>
 <div class="listing-subtitle"><a href="<%- item.path %>" <%= item.target ? `target="${item.target}"` : "" %> class="no-external"><%= item.subtitle %></a></div>

From c94002c4719986697537928794f488cd5deb4a70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Canouil?=
 <8896044+mcanouil@users.noreply.github.com>
Date: Wed, 2 Apr 2025 23:03:57 +0200
Subject: [PATCH 3/3] chore: Remove extra newlines in EJS templates

---
 src/resources/projects/website/listing/item-default.ejs.md | 2 --
 src/resources/projects/website/listing/item-grid.ejs.md    | 4 ----
 2 files changed, 6 deletions(-)

diff --git a/src/resources/projects/website/listing/item-default.ejs.md b/src/resources/projects/website/listing/item-default.ejs.md
index 88549577b72..2d0f10a6d7d 100644
--- a/src/resources/projects/website/listing/item-default.ejs.md
+++ b/src/resources/projects/website/listing/item-default.ejs.md
@@ -96,12 +96,10 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
 ```
 
 <% if (fields.includes('date') && item.date) { %>
-
 <div class="listing-date"><%= item.date %></div>
 <% } %>
 
 <% if (fields.includes('author') && item.author) { %>
-
 <div class="listing-author"><%= item.author %></div>
 <% } %>
 
diff --git a/src/resources/projects/website/listing/item-grid.ejs.md b/src/resources/projects/website/listing/item-grid.ejs.md
index e14aacd08db..dc1de86af33 100644
--- a/src/resources/projects/website/listing/item-grid.ejs.md
+++ b/src/resources/projects/website/listing/item-grid.ejs.md
@@ -68,12 +68,10 @@ return !["title", "image", "image-alt", "date", "author", "subtitle", "descripti
 ::: {.card-body .post-contents}
 
 <% if (showField('title')) { %>
-
 <h5 class="no-anchor card-title listing-title"><%= item.title %></h5>
 <% } %>
 
 <% if (showField('subtitle')) { %>
-
 <div class="card-subtitle listing-subtitle"><%= item.subtitle %></div>
 <% } %>
 
@@ -122,12 +120,10 @@ const flexJustify = showField('author') && showField('date') ? "justify" : showF
 ```
 
 <% if (showField('author')) { %>
-
 <div class="listing-author"><%= item.author %></div>
 <% } %>
 
 <% if (showField('date')) { %>
-
 <div class="listing-date"><%= item.date %></div>
 <% } %>