Skip to content

v2.2.x Chore - Improve tests/run_selective.py tool with better error handling and SOLID design #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coderabbitai bot opened this issue Mar 18, 2025 · 0 comments
Labels
Chore Miscellaneous chores to maintain the project

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2025

Background

This issue is created as a follow-up to a discussion in PR #330 (#330).

Proposed Improvements

The following improvements should be explored for the tests/run_selective.py tool:

  1. Exception handling improvements

    • Implement better exception handling closer to the testcases rather than in the main() function
    • Add targeted exception handling for specific error cases
  2. Modularization

    • Refactor the main() function to improve modularity
    • Extract responsibilities into separate functions following Single Responsibility Principle
  3. SOLID design improvements

    • Review the overall structure for adherence to SOLID principles
    • Improve separation of concerns
    • Consider implementing a more robust logging system for errors

Implementation Notes

  • These changes should be implemented on a separate test branch
  • The implementation should maintain compatibility with existing test workflows
  • Any changes should follow the project's coding guidelines

Related PR

This issue originated from a comment in PR #330 (#330 (comment))

CC: @reactive-firewall

@reactive-firewall reactive-firewall changed the title Improve tests/run_selective.py tool with better error handling and SOLID design v2.2.x Chore - Improve tests/run_selective.py tool with better error handling and SOLID design May 6, 2025
@reactive-firewall reactive-firewall removed their assignment May 24, 2025
@reactive-firewall reactive-firewall added the Chore Miscellaneous chores to maintain the project label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Miscellaneous chores to maintain the project
Projects
Status: To do
Development

No branches or pull requests

1 participant