Unhelpful error message when installing from git: "invalid argument: 'port'; class=Invalid (3)"

[tbu-]

When trying to install from a git repository, I get the following unhelpful error:

$ cargo install --git git+https://github.com/astral-sh/uv uv
    Updating git repository `git+https://github.com/astral-sh/uv`
error: failed to fetch into: .cargo/git/db/uv-c9e40703e19509a8

Caused by:
  invalid argument: 'port'; class=Invalid (3)

The problem seems to be caused by specifying git+https://github.com/astral-sh/uv instead of https://github.com/astral-sh/uv (note the missing git+ in the second URL).

The error message is unhelpful.

[dawedawe]

From what I see, it's only libgit2 that is giving us this error message:

Using the git cli:

CARGO_NET_GIT_FETCH_WITH_CLI=true ./target/debug/cargo install --verbose --force --git git+https://github.com/astral-sh/uv uv
    Updating git repository `git+https://github.com/astral-sh/uv`
     Running `git fetch --no-tags --verbose --force --update-head-ok 'git+https://github.com/astral-sh/uv' '+HEAD:refs/remotes/origin/HEAD'`
git: 'remote-git+https' is not a git command. See 'git --help'.
fatal: remote helper 'git+https' aborted session
error: failed to fetch into: /home/dawe/.cargo/git/db/uv-c9e40703e19509a8

Caused by:
  process didn't exit successfully: `git fetch --no-tags --verbose --force --update-head-ok 'git+https://github.com/astral-sh/uv' '+HEAD:refs/remotes/origin/HEAD'` (exit status: 128)

Using gitoxide

./target/debug/cargo install --verbose --force -Zgitoxide --git git+https://github.com/astral-sh/uv uv
    Updating git repository `git+https://github.com/astral-sh/uv`
error: failed to fetch into: /home/dawe/.cargo/git/db/uv-c9e40703e19509a8

Caused by:
  Protocol Ext("git+https") of url "git+https://github.com/astral-sh/uv" is denied per configuration

Default with libgit2:

./target/debug/cargo install --verbose --force --git git+https://github.com/astral-sh/uv uv
    Updating git repository `git+https://github.com/astral-sh/uv`
error: failed to fetch into: /home/dawe/.cargo/git/db/uv-c9e40703e19509a8

Caused by:
  invalid argument: 'port'; class=Invalid (3)

As none of the 3 seem to support git+https, how about rewriting the given url from git+https://... to https://... and telling the user in --verbose about it? @epage thoughts on this?

[epage]

Where is the git+https URL coming from?

As none of the 3 seem to support git+https, how about rewriting the given url from git+https://... to https://... and telling the user in --verbose about it? @epage thoughts on this?

I generally feel I don't know enough about these kind of areas to feel comfortable knowing its 100% safe to rewrite in these situations, particularly with our compatibility guarantees and tend to err on the side of giving hints to the user.

[tbu-]

Where is the git+https URL coming from?

It's how you specify git HTTPS URLs for pip: pip install git+https://github.com/psf/requests (https://pip.pypa.io/en/stable/topics/vcs-support/).

Seems to be the same for Arch Linux's PKGBUILDs as well.

[epage]

Ah, appears to be similar to our Package Id Specs though in Cargo's case, most people likely do not work with these directly or create them by hand.