Memory Leak

[alanhkarp]

The Rust analyzer uses a bit less than 1 GB of memory for each of my 2 projects when I start VSCode. After several weeks, it starts to get slow, no longer keeping up with my typing. When I look, I see it is consuming almost 2 GB. My project defines no macros, but I use lots of crates that do.

[lnicola]

Just to make sure, are you saying you keep it running for a couple of weeks?

[alanhkarp]

Or longer. I think the last time I shut VSCode down before this was for a MacOS update.

…

-------------- Alan Karp

On Mon, Jan 25, 2021 at 7:06 PM Laurențiu Nicola ***@***.***> wrote: Just to make sure, are you saying you keep it running for a couple of weeks? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7439 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFAT43LDUYDB56IU232LZDS3YWTHANCNFSM4WSS5MXQ> .

[flodiebold]

Can you try running the "Rust Analyzer: Memory Usage" command the next time?

[alanhkarp]

I'll try to remember.

…

-------------- Alan Karp

On Tue, Jan 26, 2021 at 2:03 AM Florian Diebold ***@***.***> wrote: Can you try running the "Rust Analyzer: Memory Usage" command the next time? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7439 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFAT4ZW7Y2CCIR7ELXXTK3S32HP5ANCNFSM4WSS5MXQ> .

[alanhkarp]

Just a data point. According to the Mac Activity Monitor, the analyzer increases its memory use by about 100 MB/day when I'm running my application a lot. The analyzer running with VSCode in another window that runs the web server I use for my visualization hasn't increased its memory use much if at all. I'm sympathetic. The first Java product I was involved in initially had a 1 KB/hour memory leak, which was a huge amount back in 1998.

…

-------------- Alan Karp

On Tue, Jan 26, 2021 at 2:03 AM Florian Diebold ***@***.***> wrote: Can you try running the "Rust Analyzer: Memory Usage" command the next time? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7439 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFAT4ZW7Y2CCIR7ELXXTK3S32HP5ANCNFSM4WSS5MXQ> .

[Halkcyon]

I noticed this as well. Over the course of an evening, ra went from ~100MB baseline to nearly 700MB and the build directory kept locking when I tried to build resulting in slow completions.

@flodiebold running the command reset the ra executable to baseline, but I don't think this is what you expected: https://gist.github.com/Halkcyon/6fbf7bd87a74597b82aba5150bb276fc

[alanhkarp]

Rust analyzer is getting slow, so I ran the memory analyzer. I can send you the output, but it doesn't look useful It's a bunch of lines like 0b TyQuery 0b TyQuery (deps) 0b TyQuery (purge) 0b ValueTyQuery 0b ValueTyQuery (deps) 0b ValueTyQuery (purge) Every line starts with 0b. Interesting. While I was typing this email, the memory use went from 1.4 GB to 530 MB in the Mac Activity Monitor.

…

-------------- Alan Karp

On Tue, Jan 26, 2021 at 2:03 AM Florian Diebold ***@***.***> wrote: Can you try running the "Rust Analyzer: Memory Usage" command the next time? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7439 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFAT4ZW7Y2CCIR7ELXXTK3S32HP5ANCNFSM4WSS5MXQ> .

[bjorn3]

Memory usage is only reported on Linux with glibc: https://github.com/rust-analyzer/rust-analyzer/blob/d8dfcc2c0cf87162ec5791121f484dd7fde8d17d/crates/profile/src/memory_usage.rs#L27

[alanhkarp]

I have another data point on slow editing responsiveness. VSCode got very slow for editing after a week or so since the last restart, so I checked and saw it was using about 1.5 GB of memory. I closed and reopened VSCode, and it started running with about 900 MB. Editing responsiveness was good, but I saw that the memory footprint quickly jumped to 2.4 GB and is now over 3.1 GB. Editing performance is still good. My experience is all with the same project.

…

-------------- Alan Karp

On Tue, Jan 26, 2021 at 2:03 AM Florian Diebold ***@***.***> wrote: Can you try running the "Rust Analyzer: Memory Usage" command the next time? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7439 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFAT4ZW7Y2CCIR7ELXXTK3S32HP5ANCNFSM4WSS5MXQ> .

[alanhkarp]

Yet another data point. The Rust analyzer is now taking almost 21 GB, but VSCode is quite responsive.

[Veykril]

This "bigger"(new) leak is due to a mistake that was found in #8181 which got introduced this week

[SimonSapin]

Hi. I have a running rust-analyser process taking 24 GB of resident memory. Is there something I can do to help find out where that space is being spent inside the process? This is in Code OSS (Archlinux’s build of VSCode).

Can you try running the "Rust Analyzer: Memory Usage" command the next time?

I only have a "Rust Analyzer: Memory Usage (Clears Database)" command, which sounds like it would destroy the evidence I’d like to investigate.

[bjorn3]

That is the right command. It calculates the memory usage by comparing the memory usage before and after clearing certain parts of the internal database used for caching.