-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyArea: Name/path resolution done by `rustc_resolve` specificallyA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Please, take this with a grain of salt as I might have misunderstood what #14082 is about.
The test added for this should check that a glob import is correctly shadowed by a non-glob import of a reexport from inside a non-pub module. Essentially:
// tests/ui/issues/issue-14082.rs
//@ check-pass
#![allow(unused_imports, dead_code)]
use foo::Foo;
mod foo {
pub use d::*; // This imports `d::Foo`.
pub use m::Foo; // But this imports `m::Foo` explicitly, which shadows `d::Foo`.
}
mod m {
pub struct Foo;
}
mod d {
pub struct Foo;
}
fn main() {}
However this was changed on this bulk refactor which removed the d::*
import.
Let me know if my understanding is correct. I'll submit a PR with a fix if that's the case.
Thanks :)
Metadata
Metadata
Assignees
Labels
A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyArea: Name/path resolution done by `rustc_resolve` specificallyA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.