Misc janitorial revamps #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epilys
requested review from
dorindabassey,
mz-pdm,
stsquad,
vireshk and
stefano-garzarella
as code owners
Bump to 2021 edition, and fix new warning lints while at it to keep CI green. Signed-off-by: Manos Pitsidianakis <[email protected]>
vhost-device-gpu is 2021 edition; bump the rustfmt.toml setting to match it. Signed-off-by: Manos Pitsidianakis <[email protected]>
vhost-device-console is 2021 edition; bump the rustfmt.toml setting to match it. Signed-off-by: Manos Pitsidianakis <[email protected]>
vhost-device-video is 2021 edition; bump the rustfmt.toml setting to match it. Signed-off-by: Manos Pitsidianakis <[email protected]>
This was referenced Jul 9, 2025
There was a problem hiding this comment.
@epilys ++ thank you very much for this!
I left just 1 comment about splitting error/warning messages, the rest LGTM!
rustfmt looks in parent directories, so we can have a single rustfmt.toml for all crates in the workspace. Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
stefano-garzarella
approved these changes
Jul 18, 2025
vireshk
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
I noticed a few inconsistencies on our Rust editions, duplication of rustfmt.toml, and some new clippy lint warnings with 1.88. Most of the commits are mechanical changes with rustfmt/clippy --fix.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.