Custom procedure identifiers

[rachel-fenichel]

What is the unique identifier for a custom procedure?

Scratch 2.0 uses the procCode, which is not unique: a user can create two different procedures with the same name, and they'll collide.

See scratchfoundation/scratch-blocks#607 (comment) and the following comments for more context.

If there's a unique identifier that is not the procCode it will need to be passed to scratch-blocks as part of a custom block definition, probably as a mutation on procedures_callnoreturn_internal and procedures_callnoreturn blocks.

[paulkaplan]

We can follow the recommendation of @cwillisf and de-dupe procCode in the VM and maintain procCode as the unique identifier.

We can de-dupe the procCode on sb2-import, and make sure that the procedure create/edit modal ends by going to the VM for a blocks refresh, instead of going directly back to scratch-blocks. That way the duplication checking can be kept entirely within the VM.