This repository was archived by the owner on Dec 11, 2019. It is now read-only.
This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Explicit setting of integrations prevents sending of user_hash
. #10
Open
Description
We a have a code that dynamically turns on or off Intercom integration depending on the user.
We hit a condition when it should send it to Intercom but it doesn't. It does try to send it but it's missing the user_hash
.
analytics.identify('id', { ... }, {
Intercom: { user_hash: 'x' },
integrations: {
All: true,
...,
Intercom: true
}
});
Removing the explicit setting fixed it.
analytics.identify('id', { ... }, {
Intercom: { user_hash: 'x' },
integrations: {
All: true,
...
}
});
However that just a work around and it makes the backend code a bit more complicated now that it has to decide to include the Intercom
key rather than just setting the value to either true or false.
It's also setting a trap for developers expecting it to just work.