Added 'profile_updated' to contact_info & member to version profile info #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug in Session where profile information can be overwritten with stale information, this is due to profile information contained within a message not containing any version information - a single scenario which results in this bug is:
In the above scenario Bob will have downloaded and processed all 1-to-1 messages before receiving the group messages, once the group messages are processed their profile data will incorrectly overwrite the newer information that was attached to the 1-to-1 messages
The solution for this is to include a
profile_updated
timestamp alongside the profile information when sending a message - the client can then compare this against their cached information in order to determine whether they should update the cacheSince
libSession
stores profile information for contacts and group members it also needs to track this value which is the purpose of this PR