Plain Bronze Walrus - weth token on sonic reverts on zero transfers, and doclaim is hardcoded to true in withdrawfromSP #162
Description
Plain Bronze Walrus
High
weth token on sonic reverts on zero transfers, and doclaim is hardcoded to true in withdrawfromSP
Summary
In Strategy.sol, when collateral is weth token, it revert the withdrawFromStabililtypool functionallity.
Root Cause
Internal Pre-conditions
while withdrawing asset from stabilitypool, do claim is true, so that coll would also be send back from stability pool, but situation can be there , that no coll to claim, and it would revert if 0 is transferred.
External Pre-conditions
N/A
Attack Path
when withdrwaFromSP is called with do claim true , it could revert if no collaletral to send back , but there are assets which should be withdrawed , but it will also revert
Impact
Withdraw functionallity would revert , as doClaim is hardcoded to true for sonic chain, if weth is coll
PoC
No response
Mitigation
it should be checked in contract if there is there coll to claim then only doclaim should be true, otherwise doclaim should be pass as false.