Skip to content

Commit fd17024

Browse files
authored
Merge pull request #147 from signnow/fix-validation
Fix validation limits, add thumbnails
2 parents c527e88 + 54c0b45 commit fd17024

File tree

4 files changed

+10
-44
lines changed

4 files changed

+10
-44
lines changed

CHANGELOG.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,18 @@ The format is based on [Keep a Changelog](http://keepachangelog.com)
55
and this project adheres to [Semantic Versioning](http://semver.org).
66

77
## [Unreleased] - TBD
8+
9+
10+
## [1.1.0] - 2023-01-23
811
### Added
912
- The `Thumbnail` property on `Model.SignNowDocument`, which allows you to get document thumbnails in small, medium and large image sizes
1013

1114
### Fixed
1215
- Fixed fails when parsing error response from auth service [#134](https://github.com/signnow/SignNow.NET/issues/134)
1316

17+
### Changed
18+
- Removed built-in validation for `LinkExpiration`
19+
1420

1521
## [1.0.0] - 2022-02-26
1622
### Added
@@ -155,7 +161,8 @@ and this project adheres to [Semantic Versioning](http://semver.org).
155161
[create freeform invite]: https://github.com/signnow/SignNow.NET/blob/develop/README.md#create-freeform-invite
156162

157163

158-
[Unreleased]: https://github.com/signnow/SignNow.NET/compare/1.0.0...HEAD
164+
[Unreleased]: https://github.com/signnow/SignNow.NET/compare/1.1.0...HEAD
165+
[1.1.0]: https://github.com/signnow/SignNow.NET/compare/1.0.0...1.1.0
159166
[1.0.0]: https://github.com/signnow/SignNow.NET/compare/0.9.0...1.0.0
160167
[0.9.0]: https://github.com/signnow/SignNow.NET/compare/0.8.0...0.9.0
161168
[0.8.0]: https://github.com/signnow/SignNow.NET/compare/0.7.0...0.8.0

SignNow.Net.Test/UnitTests/Requests/CreateEmbedLinkOptionsTest.cs

Lines changed: 0 additions & 27 deletions
This file was deleted.

SignNow.Net/Model/Requests/CreateEmbedLinkOptions.cs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
using System;
21
using System.Runtime.Serialization;
32
using Newtonsoft.Json;
43
using Newtonsoft.Json.Converters;
5-
using SignNow.Net.Exceptions;
64

75
namespace SignNow.Net.Model.Requests
86
{
@@ -21,19 +19,7 @@ public class CreateEmbedLinkOptions
2119
/// In how many minutes the link expires, ranges from 15 to 45 minutes or null.
2220
/// </summary>
2321
[JsonProperty("link_expiration")]
24-
public uint? LinkExpiration
25-
{
26-
get { return linkExpiration; }
27-
set
28-
{
29-
if (value < 15 || value > 45)
30-
{
31-
throw new ArgumentException(ExceptionMessages.AllowedRangeMustBeFrom15to45, nameof(LinkExpiration));
32-
}
33-
34-
linkExpiration = value;
35-
}
36-
}
22+
public uint? LinkExpiration { get; set; }
3723

3824
/// <summary>
3925
/// Signature invite you'd like to embed.

SignNow.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44

5-
<Version>1.0.0</Version>
5+
<Version>1.1.0</Version>
66
<Authors>signNow</Authors>
77
<Company>signNow</Company>
88
<Description>signNow.Net is a .NET 4.5+ and .NET standard class library for the signNow API. (Official Library)

0 commit comments

Comments
 (0)