Perform more code quality checks

Author: tvdijen

phpcs-simplesamlphp.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0"?>
 <ruleset name="SimpleSAMLphp">
-
   <!-- Only allow shorthand array syntax -->
   <rule ref="Generic.Arrays.DisallowLongArraySyntax" />
 
@@ -12,6 +11,9 @@
 
   <config name="installed_paths" value="vendor/slevomat/coding-standard"/>
 
+  <!-- Use fully qualified class names in annotations and PHPdoc -->
+  <rule ref="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation" />
+
   <!-- Do not allow any unused use-statements to exist -->
   <rule ref="SlevomatCodingStandard.Namespaces.UnusedUses" />
 
@@ -24,4 +26,45 @@
   <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInClosureUse" />
   <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration" />
 
+  <!-- Require one blank line between different types of use-statements -->
+  <rule ref="SlevomatCodingStandard.Namespaces.UseSpacing">
+    <properties>
+      <property name="linesCountBetweenUseTypes="1" />
+    </properties>
+  </rule>
+
+  <!-- Require two blank lines between class members -->
+  <rule ref="SlevomatCodingStandard.Classes.ClassMemberSpacing">
+    <properties>
+      <property name="linesCountBetweenMembers="2" />
+    </properties>
+  </rule>
+
+  <!-- Require one blank line between constant declarations -->
+  <rule ref="SlevomatCodingStandard.Classes.ConstantSpacing">
+    <properties>
+      <property name="minLinesCountBeforeWithComment="1" />
+      <property name="maxLinesCountBeforeWithComment="1" />
+      <property name="minLinesCountBeforeWithoutComment="1" />
+      <property name="maxLinesCountBeforeWithoutComment="1" />
+    </properties>
+  </rule>
+
+  <!-- Require one blank line between property definitions -->
+  <rule ref="SlevomatCodingStandard.Classes.PropertySpacing">
+    <properties>
+      <property name="minLinesCountBeforeWithComment="1" />
+      <property name="maxLinesCountBeforeWithComment="1" />
+      <property name="minLinesCountBeforeWithoutComment="1" />
+      <property name="maxLinesCountBeforeWithoutComment="1" />
+    </properties>
+  </rule>
+
+  <!-- Require two blank lines between method declarations -->
+  <rule ref="SlevomatCodingStandard.Classes.MethodSpacing ">
+    <properties>
+      <property name="minLinesCount="2" />
+      <property name="maxLinesCount="2" />
+    </properties>
+  </rule>
 </ruleset>