Rule proposal: Enforce `.toArray()` at the end of `Iterator` methods chain

[fisker]

Description

Note that it's a good idea to call toArray() as a last step of your processing. For example, fibonacci().take(10).toArray().filter(...) is less efficient, because iterator helpers are lazy and avoids creating a temporary array.

From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator/toArray

Examples

// ❌
foo.toArray().filter(...)
//            ^^^^^^ Array#filter()

// ✅
foo.filter(...).toArray()
//  ^^^^^^ Iterator#filter()

Proposed rule name

not sure

Additional Info

No response

[sindresorhus]

Accepted.

Name: prefer-to-array-at-end ?

[fisker]

Maybe prefer-iterator-to-array-at-end to be more specific? We have the object name in the name like prefer-{array,string}....

[sindresorhus]

👍

[fregante]

iterator-to-array-last? Does every name have to include prefer?

[sindresorhus]

That's the ESLint convention.