pvtServerStart hardwired to WiFi?

[PaulZC]

This code causes a crash on the Reference Station when it is connected to Ethernet.

To replicate:

• Install firmware 4.2 on a Reference Station
• Connect to Ethernet
• Reset settings to the factory default (s r y)
• Let the survey-in complete
• Open the menu and enable PVT Server (7 4 x x)

[PaulZC]

If I:

• Give the Reference Station WiFi credentials
• Disconnect the Ethernet cable
• Restart the Ref Stn, leaving PVT Server enabled

The Ref Stn connects to WiFi and I am able to connect on port 2948 and see the NMEA stream

If I then disable PVT Server, WiFi stops as it has no clients.

If I then connect Ethernet and restart the PVT Server, it continues past the crash point - presumably because WiFi has previously been started. But, the PVT server IP address is all zeros. Presumably it is getting that IP address from the disconnected WiFi?

Ethernet IP address: 192.168.0.17
PVT server online, IP address 0.0.0.0:2948

I'm wondering if we need a separate NetworkServer class, which can use Ethernet or WiFi as the transport. But I can't see how we can get past the WiFiServer.begin crash, unless we spin up WiFi and then switch to Ethernet?

[PaulZC]

Note to self: remember this is core 2.0.2. Ethernet and WiFi are intimately linked. Ethernet is really just WiFi over cable...

[PaulZC]

Second note to self: We're not using ESP32 ETH. We're using standard Arduino Ethernet... (I think I must have decided to do that for NTP UDP - where we need access to the W5500 interrupt and socket index.) The solution to this issue will - I think - be a NetworkServer class which uses EthernetServer and accepts connections from EthernetClient.

[PaulZC]

Resolved by #798