From def6f24528fbaa37168a3addca442e9491e5a306 Mon Sep 17 00:00:00 2001 From: Jonatan Ivanov Date: Fri, 5 Sep 2025 13:52:14 -0700 Subject: [PATCH] Use isNoop() instead of Observation.NOOP --- .../autoconfigure/ObservationAutoConfigurationTests.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/module/spring-boot-micrometer-observation/src/test/java/org/springframework/boot/micrometer/observation/autoconfigure/ObservationAutoConfigurationTests.java b/module/spring-boot-micrometer-observation/src/test/java/org/springframework/boot/micrometer/observation/autoconfigure/ObservationAutoConfigurationTests.java index 1efb558b3c55..60342f4e381d 100644 --- a/module/spring-boot-micrometer-observation/src/test/java/org/springframework/boot/micrometer/observation/autoconfigure/ObservationAutoConfigurationTests.java +++ b/module/spring-boot-micrometer-observation/src/test/java/org/springframework/boot/micrometer/observation/autoconfigure/ObservationAutoConfigurationTests.java @@ -99,11 +99,11 @@ void autoConfiguresObservationPredicates() { ObservationRegistry observationRegistry = context.getBean(ObservationRegistry.class); // This is allowed by ObservationPredicates.customPredicate Observation observation = Observation.start("observation1", observationRegistry); - assertThat(observation).isNotEqualTo(Observation.NOOP); + assertThat(observation.isNoop()).isFalse(); observation.stop(); // This isn't allowed by ObservationPredicates.customPredicate observation = Observation.start("observation2", observationRegistry); - assertThat(observation).isEqualTo(Observation.NOOP); + assertThat(observation.isNoop()).isTrue(); observation.stop(); }); } @@ -150,7 +150,7 @@ void shouldNotDisableSpringSecurityObservationsByDefault() { this.contextRunner.run((context) -> { ObservationRegistry observationRegistry = context.getBean(ObservationRegistry.class); Observation observation = Observation.start("spring.security.filterchains", observationRegistry); - assertThat(observation).isNotEqualTo(Observation.NOOP); + assertThat(observation.isNoop()).isFalse(); observation.stop(); }); } @@ -160,7 +160,7 @@ void shouldDisableSpringSecurityObservationsIfPropertyIsSet() { this.contextRunner.withPropertyValues("management.observations.enable.spring.security=false").run((context) -> { ObservationRegistry observationRegistry = context.getBean(ObservationRegistry.class); Observation observation = Observation.start("spring.security.filterchains", observationRegistry); - assertThat(observation).isEqualTo(Observation.NOOP); + assertThat(observation.isNoop()).isTrue(); observation.stop(); }); }