Skip to content

Commit a74ce06

Browse files
ngocnhan-tran1996jzheaux
authored andcommitted
Remove JwtIssuer(Reactive)AuthenticationManagerResolver deprecations
Signed-off-by: Tran Ngoc Nhan <[email protected]>
1 parent afb3d5d commit a74ce06

File tree

8 files changed

+7
-576
lines changed

8 files changed

+7
-576
lines changed

config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2559,8 +2559,8 @@ static class MultipleIssuersConfig {
25592559
SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
25602560
String issuerOne = this.web.url("/issuerOne").toString();
25612561
String issuerTwo = this.web.url("/issuerTwo").toString();
2562-
JwtIssuerAuthenticationManagerResolver authenticationManagerResolver = new JwtIssuerAuthenticationManagerResolver(
2563-
issuerOne, issuerTwo);
2562+
JwtIssuerAuthenticationManagerResolver authenticationManagerResolver = JwtIssuerAuthenticationManagerResolver
2563+
.fromTrustedIssuers(issuerOne, issuerTwo);
25642564
// @formatter:off
25652565
http
25662566
.oauth2ResourceServer((server) -> server

config/src/test/kotlin/org/springframework/security/config/annotation/web/OAuth2ResourceServerDslTests.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ class OAuth2ResourceServerDslTests {
223223

224224
companion object {
225225
val RESOLVER: AuthenticationManagerResolver<HttpServletRequest> =
226-
JwtIssuerAuthenticationManagerResolver("issuer")
226+
JwtIssuerAuthenticationManagerResolver.fromTrustedIssuers ("issuer")
227227
}
228228

229229
@Bean

config/src/test/kotlin/org/springframework/security/config/web/server/ServerOAuth2ResourceServerDslTests.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ class ServerOAuth2ResourceServerDslTests {
247247
open class AuthenticationManagerResolverConfig {
248248

249249
companion object {
250-
val RESOLVER: ReactiveAuthenticationManagerResolver<ServerWebExchange> = JwtIssuerReactiveAuthenticationManagerResolver("issuer")
250+
val RESOLVER: ReactiveAuthenticationManagerResolver<ServerWebExchange> = JwtIssuerReactiveAuthenticationManagerResolver.fromTrustedIssuers("issuer")
251251
}
252252

253253
@Bean

config/src/test/resources/org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests-MultipleIssuers.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@
2222
http://www.springframework.org/schema/beans https://www.springframework.org/schema/beans/spring-beans.xsd">
2323

2424
<b:bean name="authenticationManagerResolver"
25-
class="org.springframework.security.oauth2.server.resource.authentication.JwtIssuerAuthenticationManagerResolver">
26-
<b:constructor-arg>
25+
class="org.springframework.security.oauth2.server.resource.authentication.JwtIssuerAuthenticationManagerResolver"
26+
factory-method="fromTrustedIssuers">
27+
<b:constructor-arg type="java.lang.String[]">
2728
<b:list>
2829
<b:value>${issuer-one}</b:value>
2930
<b:value>${issuer-two}</b:value>

oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolver.java

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -63,30 +63,6 @@ public final class JwtIssuerAuthenticationManagerResolver implements Authenticat
6363

6464
private final AuthenticationManager authenticationManager;
6565

66-
/**
67-
* Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided
68-
* parameters
69-
* @param trustedIssuers an array of trusted issuers
70-
* @deprecated use {@link #fromTrustedIssuers(String...)}
71-
*/
72-
@Deprecated(since = "6.2", forRemoval = true)
73-
public JwtIssuerAuthenticationManagerResolver(String... trustedIssuers) {
74-
this(Set.of(trustedIssuers));
75-
}
76-
77-
/**
78-
* Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided
79-
* parameters
80-
* @param trustedIssuers a collection of trusted issuers
81-
* @deprecated use {@link #fromTrustedIssuers(Collection)}
82-
*/
83-
@Deprecated(since = "6.2", forRemoval = true)
84-
public JwtIssuerAuthenticationManagerResolver(Collection<String> trustedIssuers) {
85-
Assert.notEmpty(trustedIssuers, "trustedIssuers cannot be empty");
86-
this.authenticationManager = new ResolvingAuthenticationManager(
87-
new TrustedIssuerJwtAuthenticationManagerResolver(Set.copyOf(trustedIssuers)::contains));
88-
}
89-
9066
/**
9167
* Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided
9268
* parameters

oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerReactiveAuthenticationManagerResolver.java

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -68,30 +68,6 @@ public final class JwtIssuerReactiveAuthenticationManagerResolver
6868

6969
private final ReactiveAuthenticationManager authenticationManager;
7070

71-
/**
72-
* Construct a {@link JwtIssuerReactiveAuthenticationManagerResolver} using the
73-
* provided parameters
74-
* @param trustedIssuers an array of trusted issuers
75-
* @deprecated use {@link #fromTrustedIssuers(String...)}
76-
*/
77-
@Deprecated(since = "6.2", forRemoval = true)
78-
public JwtIssuerReactiveAuthenticationManagerResolver(String... trustedIssuers) {
79-
this(Set.of(trustedIssuers));
80-
}
81-
82-
/**
83-
* Construct a {@link JwtIssuerReactiveAuthenticationManagerResolver} using the
84-
* provided parameters
85-
* @param trustedIssuers a collection of trusted issuers
86-
* @deprecated use {@link #fromTrustedIssuers(Collection)}
87-
*/
88-
@Deprecated(since = "6.2", forRemoval = true)
89-
public JwtIssuerReactiveAuthenticationManagerResolver(Collection<String> trustedIssuers) {
90-
Assert.notEmpty(trustedIssuers, "trustedIssuers cannot be empty");
91-
this.authenticationManager = new ResolvingAuthenticationManager(
92-
new TrustedIssuerJwtAuthenticationManagerResolver(Set.copyOf(trustedIssuers)::contains));
93-
}
94-
9571
/**
9672
* Construct a {@link JwtIssuerReactiveAuthenticationManagerResolver} using the
9773
* provided parameters

oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/authentication/JwtIssuerAuthenticationManagerResolverDeprecatedTests.java

Lines changed: 0 additions & 259 deletions
This file was deleted.

0 commit comments

Comments
 (0)