short hash suport

[ankurmittal]

[orirawlings]

Hey @ankurmittal,

Can you elaborate?

Is there a reason you can't do something like:

var h plumbing.Hash
h.String()[:6]

[ankurmittal]

I can and that works but then i would also need to read "core.abbrev", i was wondering if there can be native support inside go-git, also does go-git has plan of supporting short hashes once it supports rev-parse?

[mcuadros]

This is something to think about it, where is the frontier of the user and the library. Short hashes looks more like a concept for the user that something for a library.

The config object should support read/write the core.abbrev, in other to the people, short hashes for his users. But I am not sure if adding a method Short(length int) to plumbing.Hash make sense.

[smola]

Note that to actual mimick git behaviour, we cannot just get a fixed-length prefix. An EncodedObjectStorer is needed to check for collisions and use a longer prefix if needed. So this is unlikely to make sense for plumbing.Hash, but it might make sense as an utility function that takes a plumbing.Hash and a storer.